Attachment 253411 Details for Bug 373741 – patch -- fix oops when null auth is used on second cifs mount to same server

[patch] patch -- fix oops when null auth is used on second cifs mount to same server

0001-CIFS-fix-oops-at-mount-when-null-auth-is-used.patch (text/plain), 1.46 KB, created by Jeff Layton on 2007-11-09 20:45:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2007-11-09 20:45:33 UTC

Size: 1.46 KB

patch

obsolete

>To: linux-cifs-client@lists.samba.org
>Cc: "Steve French" <smfrench@gmail.com>
>From: Jeff Layton <jlayton@redhat.com>
>Subject: [PATCH] [CIFS] fix oops at mount when null auth is used
>
>When a share is mounted using no username, cifs_mount sets
>volume_info.username as a NULL pointer, and the sesInfo userName as an
>empty string. The volume_info.username is passed to a couple of other
>functions to see if there is an existing unc or tcp connection that can
>be used. These functions assume that the username will be a valid
>string that can be passed to strncmp. If the pointer is NULL, then the
>kernel will oops if there's an existing session to which the string
>can be compared.
>
>This patch changes cifs_mount to set volume_info.username to an empty
>string in this situation, which prevents the oops and should make it
>so that the comparison to other null auth sessions match.
>
>Signed-off-by: Jeff Layton <jlayton@redhat.com>
>---
> fs/cifs/connect.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>index 380ee99..1102160 100644
>--- a/fs/cifs/connect.c
>+++ b/fs/cifs/connect.c
>@@ -1790,7 +1790,7 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
> 
> 	if (volume_info.nullauth) {
> 		cFYI(1, ("null user"));
>-		volume_info.username = NULL;
>+		volume_info.username = "";
> 	} else if (volume_info.username) {
> 		/* BB fixme parse for domain name here */
> 		cFYI(1, ("Username: %s", volume_info.username));
>-- 
>1.5.3.3
>

Actions: View | Diff

Attachments on bug 373741: 253411