Attachment 258281 Details for Bug 360051 – patch -- don't apply CTO getattr to symlink

[patch] patch -- don't apply CTO getattr to symlink

linux-2.6.9-symlink-getattr-optimize.patch (text/plain), 1.43 KB, created by Jeff Layton on 2007-11-14 16:23:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2007-11-14 16:23:06 UTC

Size: 1.43 KB

patch

obsolete

>To: rhkernel-list@redhat.com
>From: Jeff Layton <jlayton@redhat.com>
>Subject: [RHEL4.7 PATCH] BZ#291591: NFS: optimize away excessive GETATTR when file is symlinked
>
>One of our customers noticed that they were seeing significant slowdowns
>when running builds on RHEL4. After some excellent debugging work on
>their end, they tracked it down to extra GETATTR operations when dealing
>with symlinked files.
>
>Quoting Trond's description of the upstream patch:
>
>"In the case when compiling via a symlink tree, we want to ensure that the
>close-to-open GETATTR call is applied only to the final file, and not to
>the symlink."
>
>This patch is backported from one that's been upstream a long time. It
>brings the behavior of RHEL4's client into line with that of RHEL5 when
>dealing with symlinked files.
>
>Verified by the customer and myself, using their reproducer.
>
>---
> fs/nfs/dir.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
>index 6564798..a5b2cbf 100644
>--- a/fs/nfs/dir.c
>+++ b/fs/nfs/dir.c
>@@ -661,7 +661,9 @@ int nfs_lookup_verify_inode(struct inode *inode, struct nameidata *nd)
> 		/* This is an open(2) */
> 		if ((ndflags & LOOKUP_OPEN) &&
> 				!(ndflags & LOOKUP_CONTINUE) &&
>-				!(server->flags & NFS_MOUNT_NOCTO))
>+				!(server->flags & NFS_MOUNT_NOCTO) &&
>+				(S_ISREG(inode->i_mode) ||
>+				 S_ISDIR(inode->i_mode)))
> 			goto out_force;
> 	}
> 	return nfs_revalidate_inode(server, inode);
>-- 
>1.5.2.1
>

Actions: View | Diff

Attachments on bug 360051: 258281