Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 259551 Details for
Bug 375731
yum-presto not working as expected
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
Updated presto.py
presto.py (text/x-python), 13.57 KB, created by
Jonathan Dieter
on 2007-11-15 07:16:00 UTC
(
hide
)
Description:
Updated presto.py
Filename:
MIME Type:
Creator:
Jonathan Dieter
Created:
2007-11-15 07:16:00 UTC
Size:
13.57 KB
patch
obsolete
># author: Jonathan Dieter <jdieter@gmail.com> ># ># heavily modified from yum-deltarpm.py created by ># Lars Herrmann <herrmann@redhat.com> ># ># This program is free software; you can redistribute it and/or modify ># it under the terms of the GNU General Public License as published by ># the Free Software Foundation; either version 2 of the License, or ># (at your option) any later version. ># ># This program is distributed in the hope that it will be useful, ># but WITHOUT ANY WARRANTY; without even the implied warranty of ># MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the ># GNU Library General Public License for more details. ># ># You should have received a copy of the GNU General Public License ># along with this program; if not, write to the Free Software ># Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. ># Copyright 2005 Duke University ># Copyright 2007 Jonathan Dieter ># Copyright 2007 Red Hat, Inc. -- Jeremy Katz <katzj@redhat.com> > >import os >import sys >import subprocess >import gzip >import thread >import threading >import Queue >try: > from cElementTree import iterparse >except: > from xml.etree.cElementTree import iterparse > >from yum.plugins import TYPE_CORE, PluginYumExit >import yum.Errors >import yum.misc >from urlgrabber.grabber import URLGrabError > > >requires_api_version = '2.1' >plugin_type = (TYPE_CORE,) > ># mapping of repo.id -> PrestoInfo >pinfo = {} > >def verifyDelta(sequence, arch): > if subprocess.call(["/usr/bin/applydeltarpm", "-a", arch, > "-C", "-s", sequence], close_fds=True): > return False > return True > >def applyDelta(deltarpmfile, newrpmfile, arch): > if subprocess.call(["/usr/bin/applydeltarpm", "-a", arch, > deltarpmfile, newrpmfile], close_fds=True): > return False > return True > >def reconstruct(conduit, rpmlocal, rpmarch, deltalocal): > retlist = "" > > if not applyDelta(deltalocal, rpmlocal, rpmarch): > retlist += "Error rebuilding rpm from %s! Will download full package.\n" % os.path.basename(deltalocal) > try: > os.unlink(rpmlocal) > except: > pass > else: > # Check to see whether or not we should keep the drpms > # FIXME: Is there any way to see whether or not a Boolean option was not set? > if conduit.confBool('main', 'neverkeepdeltas'): > delete = True > elif conduit.confBool('main', 'keepdeltas'): > delete = False > elif conduit.getConf().keepcache != 0: > delete = False > else: > delete = True > > if delete: > try: > os.unlink(deltalocal) > except: > pass > return retlist > >class ReconstructionThread(threading.Thread): > def __init__(self, queue, lock, run_function): > threading.Thread.__init__(self) > self.run_function = run_function > self.queue = queue > self.lock = lock > self.can_exit = False > self.messages = "" > > def run(self): > while True: > try: > retval = self.queue.get(not self.can_exit) > except Queue.Empty: > # If we're done with our drpms and no more are coming, let's > # blow this joint > break > if retval != None: > messages = apply(self.run_function, retval) > if self.can_exit: > # If there are not going to be any more new drpms, > # send messages directly to conduit > conduit = retval[0] > if self.messages != "": > conduit.info(2, self.messages[:-1]) > self.messages = "" > if messages != "": > conduit.info(2, messages[:-1]) > else: > # We may be downloading drpms still, so queue messages > self.lock.acquire() > self.messages += messages > self.lock.release() > > >def getDelta(po, presto, rpmdb): > """Does the package have a reasonable delta for us to use?""" > > # local packages don't make sense to use a delta for... > if hasattr(po, 'pkgtype') and po.pkgtype == 'local': > return None > if po.remote_url.startswith("file:/"): > # kind of a hack, but file:/ repos are basically local > return None > > # if there's not presto info for the repo, we don't have a delta for > # the package > if not presto.has_key(po.repo.id): > return None > deltainfo = presto[po.repo.id] > > # any deltas for the new package in the repo? > nevra = "%s-%s:%s-%s.%s" %(po.name, po.epoch, po.version, > po.release, po.arch) > if not deltainfo.has_key(nevra): > return None > deltas = deltainfo[nevra] > > # check to see if we've already got the full package > local = po.localPkg() > if os.path.exists(local): > cursize = os.stat(local)[6] > totsize = long(po.size) > if po.verifyLocalPkg(): # we've got it. > return None > if cursize < totsize: # we have part of the file; do a reget > return None > os.unlink(local) > > # did we have a previous package of the same arch installed? > installed = rpmdb.searchNevra(po.name, None, None, None, po.arch) > if len(installed) == 0: > return None > > # now, let's see if there's a delta for us... > bestdelta = None > > for oldpo in installed: > evr = "%s:%s-%s" %(oldpo.epoch, oldpo.version, oldpo.release) > if not deltas.has_key(evr): > continue > delta = deltas[evr] > > # we just want to use the smallest delta > if bestdelta and delta['size'] >= bestdelta['size']: > continue > > if not verifyDelta(delta['sequence'], po.arch): > continue > > bestdelta = delta > > return bestdelta > > >def downloadPkgs(conduit, presto): > """download list of package objects handed to you, return errors""" > > errors = {} > def adderror(po, msg): > errors.setdefault(po, []).append(msg) > > # Set up thread for applying drpms > queue = Queue.Queue(0) > lock = thread.allocate_lock() > curthread = ReconstructionThread(queue, lock, reconstruct) > curthread.start() > > remote_pkgs = [] > > # see which deltas we need to download; if the delta is already > # downloaded, we can start it reconstructing in the background > for po in conduit.getDownloadPackages(): > delta = getDelta(po, presto, conduit.getRpmDB()) > if delta is None: > continue > > # verify the delta if it already exists > deltadir = os.path.join(po.repo.cachedir, 'deltas') > if not os.path.isdir(deltadir): > try: > os.mkdir(deltadir) > except OSError: > continue > deltapath = os.path.join(deltadir, > os.path.basename(delta['filename'])) > if os.path.exists(deltapath): > try: > conduit._base.verifyChecksum(deltapath, delta['checksum_type'], > delta['checksum']) > except URLGrabError, e: > if po.repo.cache: > raise yum.Errors.RepoError, "Caching enabled and local cache for %s doesn't match checksum" %(deltapath,) > else: > cursize = os.stat(deltapath)[6] > totsize = long(delta['size']) > if cursize >= totsize: > os.unlink(deltapath) > > remote_pkgs.append( (po, delta) ) > else: > # Deltarpm is local and good, put it in the rebuild thread. > conduit.info(5, "using local copy of deltarpm for %s" % po) > queue.put((conduit, po.localpath, po.arch, deltapath)) > continue > else: > remote_pkgs.append( (po, delta) ) > > # now we need to do downloads > i = 0 > for (po, delta) in remote_pkgs: > i += 1 > # FIXME: verifyChecksum should handle the urlgrabber objects... > checkfunc = (lambda fo, csumtype, csum: > conduit._base.verifyChecksum(fo.filename, csumtype, csum), > (delta['checksum_type'], > delta['checksum']), {}) > > deltadir = os.path.join(po.repo.cachedir, 'deltas') > deltapath = os.path.join(deltadir, > os.path.basename(delta['filename'])) > > # FIXME: this should be moved into _getFile > dirstat = os.statvfs(deltadir) > if (dirstat.f_bavail * dirstat.f_bsize) <= long(po.size): > adderror(po, 'Insufficient space in download directory %s ' > 'to download' % (deltadir,)) > continue > try: > text = "(%s/%s): %s" %(i, len(remote_pkgs), > os.path.basename(delta['filename'])) > deltafile = po.repo._getFile(url=po.basepath, > relative=delta['filename'], > local=deltapath, > checkfunc=checkfunc, > text=text, > cache=po.repo.cache) > except yum.Errors.RepoError, e: > adderror(po, str(e)) > else: > queue.put((conduit, po.localpath, po.arch, deltafile)) > > if errors.has_key(po): > del errors[po] > > # Check for waiting messages from building thread > lock.acquire() > if curthread.messages != "": > conduit.info(2, curthread.messages[:-1]) > curthread.messages = "" > lock.release() > > conduit.info(2, "Rebuilding rpms from deltarpms") > > # Tell build thread that there are no more drpms and wait for it to exit > curthread.can_exit = True > queue.put(None) > curthread.join() > > if curthread.messages != "": > conduit.info(2, curthread.messages[:-1]) > curthread.messages = "" > > return errors > >class DeltaInfo(object): > def __init__(self, elem): > self.epoch = elem.get("oldepoch") > self.version = elem.get("oldversion") > self.release = elem.get("oldrelease") > > self.filename = self.sequence = self.size = self.checksum = self.checksum_type = None > > for x in elem.getchildren(): > if x.tag == "checksum": > self.checksum_type = x.get("type") > setattr(self, x.tag, x.text) > > def evr(self): > return "%s:%s-%s" %(self.epoch, self.version, self.release) > > def __str__(self): > return "filename: %s, sequence: %s, size: %s, checksum (%s) = %s" % (self.filename, self.sequence, self.size, self.checksum_type, self.checksum) > > def __getitem__(self, key): > return getattr(self, key) > >class NewPackage(object): > def __init__(self, elem): > for prop in ("name", "version", "release", "epoch", "arch"): > setattr(self, prop, elem.get(prop)) > > self.deltas = {} > for child in elem.getchildren(): > if child.tag != "delta": > continue > d = DeltaInfo(child) > self.deltas[d.evr()] = d > > def nevra(self): > return "%s-%s:%s-%s.%s" %(self.name, self.epoch, self.version, > self.release, self.arch) > > def __str__(self): > return "%s <== %s" % (self.nevra(), self.deltas) > > def has_key(self, key): > return self.deltas.has_key(key) > def __getitem__(self, key): > return self.deltas[key] > >class PrestoParser(object): > def __init__(self, filename): > self.deltainfo = {} > > if filename.endswith(".gz"): > fo = gzip.open(filename) > else: > fo = open(filename, 'rt') > for event, elem in iterparse(fo): > if elem.tag == "newpackage": > p = NewPackage(elem) > self.deltainfo[p.nevra()] = p > > def getDeltas(self): > return self.deltainfo > > ># Configuration stuff >def config_hook(conduit): > # Add --disable-presto option > parser = conduit.getOptParser() > if parser: > parser.add_option('', '--disablepresto', dest='disablepresto', > action='store_true', default=False, > help="disable Presto plugin and don't download any deltarpms") > ># Set up Presto repositories >def postreposetup_hook(conduit): > opts, commands = conduit.getCmdLine() > if not opts or not opts.disablepresto: > conduit.info(2, 'Setting up and reading Presto delta metadata') > for active_repo in conduit.getRepos().listEnabled(): > try: > deltamd = active_repo.retrieveMD("prestodelta") > except: > conduit.info(2, "No Presto metadata available for %s" %(active_repo,)) > continue > pinfo[active_repo.id] = PrestoParser(deltamd).getDeltas() > else: > conduit.info(5, '--disablepresto specified - Presto disabled') > > >def predownload_hook(conduit): > opts, commands = conduit.getCmdLine() > if (opts and opts.disablepresto) or len(conduit.getDownloadPackages()) == 0: > return > > conduit.info(2, "Downloading DeltaRPMs:") > > # Download deltarpms > problems = downloadPkgs(conduit, pinfo) > > # If 'exitondownloaderror' is on, exit > if conduit.confBool('main', 'exitondownloaderror') and \ > len(problems.keys()) > 0: > errstring = 'Error Downloading DeltaRPMs:\n' > for key in problems.keys(): > errors = yum.misc.unique(problems[key]) > for error in errors: > errstring += ' %s: %s\n' % (key, error) > raise PluginYumExit(errstring) > ># FIXME: would be good to give an idea to people of what they saved
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 375731
:
254381
|
254791
|
255771
| 259551 |
259631