Attachment 260401 Details for Bug 381221 – patch to fix the problem.

[patch] patch to fix the problem.

symlink-jbd-rhel4-fix.patch (text/plain), 2.68 KB, created by Josef Bacik on 2007-11-15 21:18:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Bacik

Created: 2007-11-15 21:18:13 UTC

Size: 2.68 KB

patch

obsolete

>diff -up linux-2.6.9/include/linux/fs.h.josef linux-2.6.9/include/linux/fs.h
>--- linux-2.6.9/include/linux/fs.h.josef	2007-11-15 16:12:17.000000000 -0500
>+++ linux-2.6.9/include/linux/fs.h	2007-11-15 16:16:13.000000000 -0500
>@@ -1591,6 +1591,8 @@ extern int vfs_follow_link(struct nameid
> extern int page_readlink(struct dentry *, char __user *, int);
> extern int page_follow_link_light(struct dentry *, struct nameidata *);
> extern void page_put_link(struct dentry *, struct nameidata *);
>+extern int __page_symlink(struct inode *inode, const char *symname, int len,
>+		gfp_t gfp_mask);
> extern int page_symlink(struct inode *inode, const char *symname, int len);
> extern struct inode_operations page_symlink_inode_operations;
> extern int generic_readlink(struct dentry *, char __user *, int);
>diff -up linux-2.6.9/fs/namei.c.josef linux-2.6.9/fs/namei.c
>--- linux-2.6.9/fs/namei.c.josef	2007-11-15 16:12:17.000000000 -0500
>+++ linux-2.6.9/fs/namei.c	2007-11-15 16:15:01.000000000 -0500
>@@ -2420,13 +2420,15 @@ void page_put_link(struct dentry *dentry
> 	}
> }
> 
>-int page_symlink(struct inode *inode, const char *symname, int len)
>+int __page_symlink(struct inode *inode, const char *symname, int len,
>+		gfp_t gfp_mask)
> {
> 	struct address_space *mapping = inode->i_mapping;
>-	struct page *page = grab_cache_page(mapping, 0);
>+	struct page *page;
> 	int err = -ENOMEM;
> 	char *kaddr;
> 
>+	page = find_or_create_page(mapping, 0, gfp_mask);
> 	if (!page)
> 		goto fail;
> 	err = mapping->a_ops->prepare_write(NULL, page, 0, len-1);
>@@ -2461,6 +2463,12 @@ fail:
> 	return err;
> }
> 
>+int page_symlink(struct inode *inode, const char *symname, int len)
>+{
>+	return __page_symlink(inode, symname, len,
>+			mapping_gfp_mask(inode->i_mapping));
>+}
>+
> struct inode_operations page_symlink_inode_operations = {
> 	.readlink	= generic_readlink,
> 	.follow_link	= page_follow_link_light,
>@@ -2478,6 +2486,7 @@ EXPORT_SYMBOL(lookup_one_len);
> EXPORT_SYMBOL(page_follow_link_light);
> EXPORT_SYMBOL(page_put_link);
> EXPORT_SYMBOL(page_readlink);
>+EXPORT_SYMBOL(__page_symlink);
> EXPORT_SYMBOL(page_symlink);
> EXPORT_SYMBOL(page_symlink_inode_operations);
> EXPORT_SYMBOL(path_lookup);
>diff -up linux-2.6.9/fs/ext3/namei.c.josef linux-2.6.9/fs/ext3/namei.c
>--- linux-2.6.9/fs/ext3/namei.c.josef	2007-11-15 16:11:57.000000000 -0500
>+++ linux-2.6.9/fs/ext3/namei.c	2007-11-15 16:15:01.000000000 -0500
>@@ -2181,7 +2181,8 @@ retry:
> 		 * We have a transaction open.  All is sweetness.  It also sets
> 		 * i_size in generic_commit_write().
> 		 */
>-		err = page_symlink(inode, symname, l);
>+		err = __page_symlink(inode, symname, l,
>+				mapping_gfp_mask(inode->i_mapping) & ~__GFP_FS);
> 		if (err) {
> 			ext3_dec_count(handle, inode);
> 			ext3_mark_inode_dirty(handle, inode);

Actions: View | Diff

Attachments on bug 381221: 260401