Attachment 268851 Details for Bug 397481 – Update to s-c-a-0.4.5: Fix an incorrect file size overflow check

[patch] Update to s-c-a-0.4.5: Fix an incorrect file size overflow check

sca-0.4.5.patch (text/plain), 1.81 KB, created by Miloslav Trmač on 2007-11-26 12:35:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Miloslav Trmač

Created: 2007-11-26 12:35:08 UTC

Size: 1.81 KB

patch

obsolete

>diff -r 228ea98b53e5 -r 6033dfe1fc92 ChangeLog
>--- a/ChangeLog	Sun Nov 18 13:28:02 2007 +0100
>+++ b/ChangeLog	Mon Nov 26 13:32:50 2007 +0100
>@@ -1,3 +1,11 @@ 2007-11-18  Miloslav TrmaÄ  <mitr@redha
>+2007-11-26  Miloslav TrmaÄ  <mitr@redhat.com>
>+
>+	* configure.ac: Release 0.4.5.
>+	* NEWS: Update.
>+
>+	* src/server.c (req_read_file): Fix overflow check on architectures
>+	where sizeof (off_t) <= sizeof (size_t), e.g. x86_64.
>+
> 2007-11-18  Miloslav TrmaÄ  <mitr@redhat.com>
> 
> 	* configure.ac: Release 0.4.4.
>diff -r 228ea98b53e5 -r 6033dfe1fc92 NEWS
>--- a/NEWS	Sun Nov 18 13:28:02 2007 +0100
>+++ b/NEWS	Mon Nov 26 13:32:50 2007 +0100
>@@ -1,3 +1,6 @@ Changes in release 0.4.4:
>+Changes in release 0.4.5:
>+* Fix configuration file access on x86_64 and probably other architectures
>+
> Changes in release 0.4.4:
> * Fix sensitivity of the up/down buttons when editing rule fields
> * Add a missed translatable string
>diff -r 228ea98b53e5 -r 6033dfe1fc92 configure.ac
>--- a/configure.ac	Sun Nov 18 13:28:02 2007 +0100
>+++ b/configure.ac	Mon Nov 26 13:32:50 2007 +0100
>@@ -1,5 +1,5 @@
> # Process this file with autoconf to produce a configure script.
>-AC_INIT([system-config-audit], [0.4.4], [mitr@redhat.com])
>+AC_INIT([system-config-audit], [0.4.5], [mitr@redhat.com])
> AC_COPYRIGHT(
> [Copyright (C) 2007 Red Hat, Inc.  All rights reserved.
> 
>diff -r 228ea98b53e5 -r 6033dfe1fc92 src/server.c
>--- a/src/server.c	Sun Nov 18 13:28:02 2007 +0100
>+++ b/src/server.c	Mon Nov 26 13:32:50 2007 +0100
>@@ -200,7 +200,9 @@ req_read_file (void)
>       err = errno;
>       goto err_fd;
>     }
>-  if (st.st_size > (off_t)SIZE_MAX)
>+  /* If sizeof (off_t) <= sizeof (size_t), (size_t)st.st_size cannot overflow
>+     and (off_t)SIZE_MAX is negative. */
>+  if (sizeof (off_t) > sizeof (size_t) && st.st_size > (off_t)SIZE_MAX)
>     {
>       err = EFBIG;
>       goto err_fd;

Actions: View | Diff

Attachments on bug 397481: 268851