Attachment 271791 Details for Bug 307431 – Remove permission checks from xattr ops

[patch] Remove permission checks from xattr ops

gfs2_xattr_permission.diff (text/plain), 1.95 KB, created by Ryan O'Hara on 2007-11-28 21:02:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ryan O'Hara

Created: 2007-11-28 21:02:30 UTC

Size: 1.95 KB

patch

obsolete

>--- a/fs/gfs2/eaops.c	2007-11-28 14:32:06.000000000 -0600
>+++ b/fs/gfs2/eaops.c	2007-11-28 14:32:19.000000000 -0600
>@@ -57,41 +57,16 @@
> 
> static int user_eo_get(struct gfs2_inode *ip, struct gfs2_ea_request *er)
> {
>-	struct inode *inode = &ip->i_inode;
>-	int error = permission(inode, MAY_READ, NULL);
>-	if (error)
>-		return error;
>-
> 	return gfs2_ea_get_i(ip, er);
> }
> 
> static int user_eo_set(struct gfs2_inode *ip, struct gfs2_ea_request *er)
> {
>-	struct inode *inode = &ip->i_inode;
>-
>-	if (S_ISREG(inode->i_mode) ||
>-	    (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) {
>-		int error = permission(inode, MAY_WRITE, NULL);
>-		if (error)
>-			return error;
>-	} else
>-		return -EPERM;
>-
> 	return gfs2_ea_set_i(ip, er);
> }
> 
> static int user_eo_remove(struct gfs2_inode *ip, struct gfs2_ea_request *er)
> {
>-	struct inode *inode = &ip->i_inode;
>-
>-	if (S_ISREG(inode->i_mode) ||
>-	    (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) {
>-		int error = permission(inode, MAY_WRITE, NULL);
>-		if (error)
>-			return error;
>-	} else
>-		return -EPERM;
>-
> 	return gfs2_ea_remove_i(ip, er);
> }
> 
>@@ -107,8 +82,6 @@
> 	     GFS2_ACL_IS_DEFAULT(er->er_name, er->er_name_len)))
> 		return -EOPNOTSUPP;
> 
>-
>-
> 	return gfs2_ea_get_i(ip, er);
> }
> 
>@@ -171,31 +144,16 @@
> 
> static int security_eo_get(struct gfs2_inode *ip, struct gfs2_ea_request *er)
> {
>-	struct inode *inode = &ip->i_inode;
>-	int error = permission(inode, MAY_READ, NULL);
>-	if (error)
>-		return error;
>-
> 	return gfs2_ea_get_i(ip, er);
> }
> 
> static int security_eo_set(struct gfs2_inode *ip, struct gfs2_ea_request *er)
> {
>-	struct inode *inode = &ip->i_inode;
>-	int error = permission(inode, MAY_WRITE, NULL);
>-	if (error)
>-		return error;
>-
> 	return gfs2_ea_set_i(ip, er);
> }
> 
> static int security_eo_remove(struct gfs2_inode *ip, struct gfs2_ea_request *er)
> {
>-	struct inode *inode = &ip->i_inode;
>-	int error = permission(inode, MAY_WRITE, NULL);
>-	if (error)
>-		return error;
>-
> 	return gfs2_ea_remove_i(ip, er);
> }
>

Actions: View | Diff

Attachments on bug 307431: 271791