Attachment 288931 Details for Bug 251527 – xen-unstable 13763:8132bf3ddbef ported to 2.6.18-53.el5

[patch] xen-unstable 13763:8132bf3ddbef ported to 2.6.18-53.el5

xen-unstable-13763-8132bf3ddbef (text/plain), 1.26 KB, created by Ian Campbell on 2007-12-14 09:31:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Campbell

Created: 2007-12-14 09:31:30 UTC

Size: 1.26 KB

patch

obsolete

># HG changeset patch
># User Ian Campbell <ian.campbell@xensource.com>
># Date 1170325234 0
># Node ID 8132bf3ddbef6901f39694a7a9024bd92fb2a91a
># Parent  588dd80b56b5411bd9d1860e9e19da39a64e2f5d
>[LINUX] netfront: Don't call netif_carrier_off until the device is
>fuly allocated.
>
>netif_carrier_off() causes events to be queued on the device so if we
>subsequently abort the allocation (e.g. due to lack of grant entries)
>then we crash trying to access the now invalid device.
>
>Signed-off-by: Ian Campbell <ian.campbell@xensource.com>
>xen-unstable changeset: 13763:8132bf3ddbef6901f39694a7a9024bd92fb2a91a
>xen-unstable date: Thu Feb 01 10:20:34 2007 +0000
>
>diff -r 588dd80b56b5 -r 8132bf3ddbef drivers/xen/netfront/netfront.c
>--- a/drivers/xen/netfront/netfront.c	Wed Jan 31 19:37:44 2007 +0000
>+++ b/drivers/xen/netfront/netfront.c	Thu Feb 01 10:20:34 2007 +0000
>@@ -1935,8 +1935,6 @@ static struct net_device * __devinit cre
> 	np                   = netdev_priv(netdev);
> 	np->xbdev            = dev;
> 
>-	netif_carrier_off(netdev);
>-
> 	spin_lock_init(&np->tx_lock);
> 	spin_lock_init(&np->rx_lock);
> 
>@@ -1991,6 +1989,9 @@ static struct net_device * __devinit cre
> 	SET_NETDEV_DEV(netdev, &dev->dev);
> 
> 	np->netdev = netdev;
>+
>+	netif_carrier_off(netdev);
>+
> 	return netdev;
> 
>  exit_free_tx:

Actions: View | Diff

Attachments on bug 251527: 288931 | 288941 | 291769