Attachment 289998 Details for Bug 426200 – Backport of xen-unstable cset 12313

[patch] Backport of xen-unstable cset 12313

linux-2.6-xen-xenoprof-passive-samples-lost.patch (text/plain), 2.30 KB, created by Markus Armbruster on 2007-12-19 09:33:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Markus Armbruster

Created: 2007-12-19 09:33:44 UTC

Size: 2.30 KB

patch

obsolete

>Derived from
># HG changeset patch
># User kfraser@localhost.localdomain
># Date 1163072862 0
># Node ID eea9247ad5a06965dc46cbcab236402dd8f7431b
># Parent  b8a2db59150a084e4e1a5a1cae660dbf7cc14c2d
>[XENOPROF] Oprofile user level samples for passive domains are being lost.
>The number of of lost samples is most significant when dom0 is idle.
>
>From: joserenato.santos@hp.com
>Signed-off-by: Keir Fraser <keir@xensource.com>
>
>diff -rupN linux-2.6.16.29-xen/drivers/oprofile/buffer_sync.c linux-2.6.16.29-xen.new/drivers/oprofile/buffer_sync.c
>--- a/drivers/oprofile/buffer_sync.c	2007-06-01 20:57:37.000000000 +0200
>+++ b/drivers/oprofile/buffer_sync.c	2007-06-01 20:52:10.000000000 +0200
>@@ -42,6 +42,7 @@ static cpumask_t marked_cpus = CPU_MASK_
> static DEFINE_SPINLOCK(task_mortuary);
> static void process_task_mortuary(void);
> 
>+static int cpu_current_domain[NR_CPUS];
> 
> /* Take ownership of the task struct and place it on the
>  * list for processing. Only after two full buffer syncs
>@@ -150,6 +151,11 @@ static void end_sync(void)
> int sync_start(void)
> {
> 	int err;
>+	int i;
>+
>+	for (i = 0; i < NR_CPUS; i++) {
>+		cpu_current_domain[i] = COORDINATOR_DOMAIN;
>+	}
> 
> 	start_cpu_work();
> 
>@@ -526,6 +532,11 @@ void sync_buffer(int cpu)
>  
> 	add_cpu_switch(cpu);
> 
>+	/* We need to assign the first samples in this CPU buffer to the
>+	   same domain that we were processing at the last sync_buffer */
>+	if (cpu_current_domain[cpu] != COORDINATOR_DOMAIN) {
>+		add_domain_switch(cpu_current_domain[cpu]);
>+	}
> 	/* Remember, only we can modify tail_pos */
> 
> 	available = get_slots(cpu_buf);
>@@ -559,10 +570,15 @@ void sync_buffer(int cpu)
> 			}
> 		} else {
> 			if (domain_switch) {
>+				cpu_current_domain[cpu] = s->eip;
> 				add_domain_switch(s->eip);
> 				domain_switch = 0;
> 			} else {
>-				if (state >= sb_bt_start &&
>+				if (cpu_current_domain[cpu] !=
>+				    COORDINATOR_DOMAIN) {
>+					add_sample_entry(s->eip, s->event);
>+				}
>+				else  if (state >= sb_bt_start &&
> 				    !add_sample(mm, s, cpu_mode)) {
> 					if (state == sb_bt_start) {
> 						state = sb_bt_ignore;
>@@ -576,6 +592,11 @@ void sync_buffer(int cpu)
> 	}
> 	release_mm(mm);
> 
>+	/* We reset domain to COORDINATOR at each CPU switch */
>+	if (cpu_current_domain[cpu] != COORDINATOR_DOMAIN) {
>+		add_domain_switch(COORDINATOR_DOMAIN);
>+	}
>+
> 	mark_done(cpu);
> 
> 	mutex_unlock(&buffer_mutex);

Actions: View | Diff

Attachments on bug 426200: 289998