Attachment 290173 Details for Bug 305231 – patch -- redo existing session setup if needed in cifs_mount

[patch] patch -- redo existing session setup if needed in cifs_mount

0001-CIFS-redo-existing-session-setup-if-needed-in-cifs.patch (text/plain), 1.80 KB, created by Jeff Layton on 2007-12-20 17:31:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2007-12-20 17:31:43 UTC

Size: 1.80 KB

patch

obsolete

>From b68447ef2a1d88957bd402bb50bcb6be474210f7 Mon Sep 17 00:00:00 2001
>From: Jeff Layton <jlayton@redhat.com>
>Date: Thu, 20 Dec 2007 10:37:31 -0500
>Subject: [PATCH] [CIFS] redo existing session setup if needed in cifs_mount
>
>When cifs_mount finds an existing SMB session that it can use for a new
>mount, it does not check to see whether that session is in need of being
>reconnected. An easy way to reproduce:
>
>1) mount //server/share1
>2) watch /proc/fs/cifs/DebugData for the share to go DISCONNECTED
>3) mount //server/share2 with same creds as in step 1.
>
>The second mount will fail because CIFSTCon returned -EAGAIN. If you do
>an operation in share1 and then reattempt the mount it will work (since
>the session is reestablished).
>
>The following patch fixes this by having cifs_mount check the status
>of the session when it picks an existing session and calling
>cifs_setup_session on it again if it's in need of reconnection.
>
>Thanks to Wojciech Pilorz for the initial bug report.
>
>Signed-off-by: Jeff Layton <jlayton@redhat.com>
>---
> fs/cifs/connect.c |   10 +++++++++-
> 1 files changed, 9 insertions(+), 1 deletions(-)
>
>diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>index fd9147c..658f58b 100644
>--- a/fs/cifs/connect.c
>+++ b/fs/cifs/connect.c
>@@ -1964,7 +1964,15 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
> 
> 	if (existingCifsSes) {
> 		pSesInfo = existingCifsSes;
>-		cFYI(1, ("Existing smb sess found"));
>+		cFYI(1, ("Existing smb sess found (status=%d)",
>+			pSesInfo->status));
>+		if (pSesInfo->status == CifsNeedReconnect) {
>+			cFYI(1, ("Session needs reconnect"));
>+			down(&pSesInfo->sesSem);
>+			rc = cifs_setup_session(xid, pSesInfo,
>+						cifs_sb->local_nls);
>+			up(&pSesInfo->sesSem);
>+		}
> 	} else if (!rc) {
> 		cFYI(1, ("Existing smb sess not found"));
> 		pSesInfo = sesInfoAlloc();
>-- 
>1.5.3.6
>

Actions: View | Diff

Attachments on bug 305231: 290173