Attachment 290313 Details for Bug 426558 – New Patch for Post-Tagging M4A Files

[patch] New Patch for Post-Tagging M4A Files

abcde-2.3.99-AtomicParsley.patch (text/plain), 2.48 KB, created by Bill Adams on 2007-12-23 23:50:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bill Adams

Created: 2007-12-23 23:50:53 UTC

Size: 2.48 KB

patch

obsolete

>--- abcde-2.3.99.6-orig/abcde	2006-08-05 12:14:00.000000000 -0700
>+++ abcde-2.3.99.6/abcde	2007-12-23 13:44:54.000000000 -0800
>@@ -763,7 +763,7 @@
> # do_tag [tracknumber]
> # id3 tags a filename
> # variables used:
>-# TRACKS, TRACKNAME, TRACKARTIST, TAGGER, TAGGEROPTS, VORBISCOMMENT, METAFLAC, 
>+# TRACKS, TRACKNAME, TRACKARTIST, TAGGER, TAGGEROPTS, VORBISCOMMENT, METAFLAC, ATOMICPARSLEY 
> # COMMENT, DALBUM, DARTIST, CDYEAR, CDGENRE (and temporarily) ID3TAGV
> do_tag ()
> {
>@@ -876,7 +876,20 @@
> 			run_command tagtrack-$OUTPUT-$1 true
> 			;;
> 		m4a)
>-			run_command tagtrack-$OUTPUT-$1 true
>+			#  Use a temp-file of our choice. --overWrite seems to
>+			#  case core dumps with AtomicParsley 0.9.0
>+			ATOMICTEMPFILE="$ABCDETEMPDIR/track$1.m4a-atomic"
>+
>+			VARIOUSBOOL="false"
>+			if [ "$VARIOUSARTISTS" = "y" ]; then
>+				VARIOUSBOOL="true"
>+			fi
>+
>+			#It has to be command file opts for AtomicParsley
>+			run_command tagtrack-$OUTPUT-$1 nice $ENCNICE $ATOMICPARSLEY $ABCDETEMPDIR/track$1.m4a --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME" --tracknum ${TRACKNUM:-$1} --year "$CDYEAR" --genre "$CDGENRE" --compilation $VARIOUSBOOL --comment "$COMMENTOUTPUT" --output $ATOMICTEMPFILE
>+			if [ -f $ATOMICTEMPFILE ]; then
>+				mv "$ATOMICTEMPFILE" "$ABCDETEMPDIR/track$1.m4a"
>+			fi
> 			;;
> 		wav)
> 			run_command tagtrack-$OUTPUT-$1 true
>@@ -2944,6 +2957,7 @@
> DISTMP3=distmp3
> VORBISCOMMENT=vorbiscomment
> METAFLAC=metaflac
>+ATOMICPARSLEY=AtomicParsley
> NORMALIZE=normalize-audio
> CDSPEED=eject
> VORBISGAIN=vorbisgain
>@@ -3462,6 +3476,7 @@
> 			;;
> 		m4a)
> 			[ "$AACENCODERSYNTAX" = "default" ] && AACENCODERSYNTAX=faac
>+			[ "$DOTAG" = "y" ] && CHECKATOMICPARSLEY=y
> 			;;
> 		wav)
> 			if [ "$KEEPWAVS" = "y" ]; then
>@@ -3684,6 +3699,7 @@
> for X in $CDROMREADER $CDDISCID ${NEEDTAGGER+$TAGGER} $MP3ENCODER \
> 	$OGGENCODER $FLACENCODER $SPEEXENCODER $MPPENCODER \
> 	$AACENCODER \
>+	${NEEDATOMICPARSLEY+$ATOMICPARSLEY} \
> 	${NEEDHTTPGET+$HTTPGET} ${NEEDDISTMP3+$DISTMP3} \
> 	${NEEDCOMMENTER+$VORBISCOMMENT} ${NEEDMETAFLAC+$METAFLAC} \
> 	${NEEDNORMALIZER+$NORMALIZER} ${NEEDEJECT+$EJECT} \
>@@ -3695,6 +3711,15 @@
> 	checkexec "$X"
> done
> 
>+if [ "$CHECKATOMICPARSLEY" = "y" ]; then
>+	if ! new_checkexec "$ATOMICPARSLEY"; then
>+		echo "WARNING: $ATOMICPARSLEY Not Found Not Post-Tagging!"
>+		DOTAG='n'
>+	else
>+		echo "Using $ATOMICPARSLEY To Tag AAC Tracks."
>+	fi
>+fi
>+
> # And last but not least, check if we can diff between files. We do not abort,
> # since diffing is not critical...
> if [ -x $(which $DIFF) ]; then :; else

Actions: View | Diff

Attachments on bug 426558: 290282 | 290283 | 290313