Attachment 290555 Details for Bug 357661 – Fix for FORTIFY_SOURCE abort of sunbird during startup

[patch] Fix for FORTIFY_SOURCE abort of sunbird during startup

sunbird-0.7-path.patch (text/plain), 7.89 KB, created by Lubomir Kundrak on 2007-12-30 19:02:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lubomir Kundrak

Created: 2007-12-30 19:02:54 UTC

Size: 7.89 KB

patch

obsolete

>FORTIFY_SOURCE aborts the process if realpath() is called with destination
>buffer smaller than PATH_MAX (typically of 4096 characters). Mozilla uses
>MAXPATHLEN that is by default defined to 1024 bytes.
>
>This originally comes from firefox-path.patch of firefox package.
>
>diff -ur mozilla.orig/config/pathsub.h mozilla/config/pathsub.h
>--- mozilla.orig/config/pathsub.h	2004-04-18 16:17:25.000000000 +0200
>+++ mozilla/config/pathsub.h	2007-12-30 19:23:26.000000000 +0100
>@@ -46,7 +46,7 @@
> #include <sys/types.h>
> 
> #ifndef PATH_MAX
>-#define PATH_MAX 1024
>+#error  "PATH_MAX is not defined!"
> #endif
> 
> /*
>diff -ur mozilla.orig/dbm/include/mcom_db.h mozilla/dbm/include/mcom_db.h
>--- mozilla.orig/dbm/include/mcom_db.h	2005-04-29 15:33:34.000000000 +0200
>+++ mozilla/dbm/include/mcom_db.h	2007-12-30 19:23:26.000000000 +0100
>@@ -214,7 +214,8 @@
> #endif  /* __DBINTERFACE_PRIVATE */
> 
> #ifdef SCO
>-#define MAXPATHLEN 	1024              
>+#include <limits.h>
>+#define MAXPATHLEN 	PATH_MAX     
> #endif
> 
> #include <fcntl.h>
>diff -ur mozilla.orig/directory/c-sdk/config/pathsub.h mozilla/directory/c-sdk/config/pathsub.h
>--- mozilla.orig/directory/c-sdk/config/pathsub.h	2006-02-03 15:41:18.000000000 +0100
>+++ mozilla/directory/c-sdk/config/pathsub.h	2007-12-30 19:23:26.000000000 +0100
>@@ -50,7 +50,7 @@
> #endif
> 
> #ifndef PATH_MAX
>-#define PATH_MAX 1024
>+#error  "PATH_MAX is not defined!"
> #endif
> 
> /*
>diff -ur mozilla.orig/gfx/src/gtk/nsPrintdGTK.h mozilla/gfx/src/gtk/nsPrintdGTK.h
>--- mozilla.orig/gfx/src/gtk/nsPrintdGTK.h	2004-04-17 23:52:29.000000000 +0200
>+++ mozilla/gfx/src/gtk/nsPrintdGTK.h	2007-12-30 19:23:26.000000000 +0100
>@@ -63,7 +63,7 @@
> #ifdef _POSIX_PATH_MAX
> #define PATH_MAX	_POSIX_PATH_MAX
> #else
>-#define PATH_MAX	256
>+#error "PATH_MAX is not defined!"
> #endif
> #endif
> 
>diff -ur mozilla.orig/js/src/jsfile.c mozilla/js/src/jsfile.c
>--- mozilla.orig/js/src/jsfile.c	2006-07-26 20:55:08.000000000 +0200
>+++ mozilla/js/src/jsfile.c	2007-12-30 19:23:26.000000000 +0100
>@@ -105,7 +105,8 @@
> #define utfstring               "binary"
> #define unicodestring           "unicode"
> 
>-#define MAX_PATH_LENGTH         1024
>+#include <limits.h>
>+#define MAX_PATH_LENGTH         PATH_MAX
> #define MODE_SIZE               256
> #define NUMBER_SIZE             32
> #define MAX_LINE_LENGTH         256
>diff -ur mozilla.orig/mailnews/import/comm4x/src/nsComm4xProfile.cpp mozilla/mailnews/import/comm4x/src/nsComm4xProfile.cpp
>--- mozilla.orig/mailnews/import/comm4x/src/nsComm4xProfile.cpp	2005-02-16 12:50:13.000000000 +0100
>+++ mozilla/mailnews/import/comm4x/src/nsComm4xProfile.cpp	2007-12-30 19:23:26.000000000 +0100
>@@ -70,7 +70,8 @@
> #elif defined(CCHMAXPATH)
> #define MAXPATHLEN CCHMAXPATH
> #else
>-#define MAXPATHLEN 1024
>+#include <limits.h>
>+#define MAXPATHLEN PATH_MAX
> #endif
> #endif
> 
>diff -ur mozilla.orig/modules/libjar/nsZipArchive.cpp mozilla/modules/libjar/nsZipArchive.cpp
>--- mozilla.orig/modules/libjar/nsZipArchive.cpp	2006-09-13 20:32:37.000000000 +0200
>+++ mozilla/modules/libjar/nsZipArchive.cpp	2007-12-30 19:23:26.000000000 +0100
>@@ -121,7 +121,7 @@
> #    define S_IFLNK  0120000
> #  endif
> #  ifndef PATH_MAX
>-#    define PATH_MAX 1024
>+#    include <limits.h>
> #  endif
> #endif  /* XP_UNIX */
> 
>diff -ur mozilla.orig/modules/libreg/src/reg.c mozilla/modules/libreg/src/reg.c
>--- mozilla.orig/modules/libreg/src/reg.c	2004-05-11 14:15:10.000000000 +0200
>+++ mozilla/modules/libreg/src/reg.c	2007-12-30 19:23:26.000000000 +0100
>@@ -96,7 +96,8 @@
> #define MAX_PATH PATH_MAX
> #elif defined(XP_UNIX)
> #ifndef MAX_PATH
>-#define MAX_PATH 1024
>+#include <limits.h>
>+#define MAX_PATH PATH_MAX
> #endif
> #elif defined(XP_OS2)
> #ifndef MAX_PATH
>diff -ur mozilla.orig/nsprpub/config/pathsub.h mozilla/nsprpub/config/pathsub.h
>--- mozilla.orig/nsprpub/config/pathsub.h	2004-04-25 17:00:34.000000000 +0200
>+++ mozilla/nsprpub/config/pathsub.h	2007-12-30 19:23:26.000000000 +0100
>@@ -50,7 +50,7 @@
> #endif
> 
> #ifndef PATH_MAX
>-#define PATH_MAX 1024
>+#error  "PATH_MAX is not defined!"
> #endif
> 
> /*
>diff -ur mozilla.orig/security/coreconf/nsinstall/pathsub.h mozilla/security/coreconf/nsinstall/pathsub.h
>--- mozilla.orig/security/coreconf/nsinstall/pathsub.h	2004-04-25 17:02:18.000000000 +0200
>+++ mozilla/security/coreconf/nsinstall/pathsub.h	2007-12-30 19:23:26.000000000 +0100
>@@ -49,7 +49,7 @@
> #endif
> 
> #ifndef PATH_MAX
>-#define PATH_MAX 1024
>+#error  "PATH_MAX is not defined!"
> #endif
> 
> /*
>diff -ur mozilla.orig/toolkit/mozapps/update/src/updater/updater.cpp mozilla/toolkit/mozapps/update/src/updater/updater.cpp
>--- mozilla.orig/toolkit/mozapps/update/src/updater/updater.cpp	2007-09-09 01:31:16.000000000 +0200
>+++ mozilla/toolkit/mozapps/update/src/updater/updater.cpp	2007-12-30 19:23:26.000000000 +0100
>@@ -107,7 +107,8 @@
> # elif defined(CCHMAXPATH)
> #  define MAXPATHLEN CCHMAXPATH
> # else
>-#  define MAXPATHLEN 1024
>+#  include <limits.h>
>+#  define MAXPATHLEN PATH_MAX
> # endif
> #endif
> 
>diff -ur mozilla.orig/toolkit/xre/nsAppRunner.h mozilla/toolkit/xre/nsAppRunner.h
>--- mozilla.orig/toolkit/xre/nsAppRunner.h	2007-04-30 19:26:58.000000000 +0200
>+++ mozilla/toolkit/xre/nsAppRunner.h	2007-12-30 19:23:26.000000000 +0100
>@@ -48,7 +48,8 @@
> #elif defined(CCHMAXPATH)
> #define MAXPATHLEN CCHMAXPATH
> #else
>-#define MAXPATHLEN 1024
>+#include <limits.h>
>+#define MAXPATHLEN PATH_MAX
> #endif
> #endif
> 
>diff -ur mozilla.orig/webshell/tests/viewer/nsViewerApp.cpp mozilla/webshell/tests/viewer/nsViewerApp.cpp
>--- mozilla.orig/webshell/tests/viewer/nsViewerApp.cpp	2005-07-21 15:33:41.000000000 +0200
>+++ mozilla/webshell/tests/viewer/nsViewerApp.cpp	2007-12-30 19:23:26.000000000 +0100
>@@ -692,7 +692,8 @@
> 
> #if !defined(XP_WIN) && !defined(XP_OS2)
> #ifndef XP_MAC
>-#define _MAX_PATH 512
>+#include <limits.h>
>+#define _MAX_PATH PATH_MAX
> #endif
> #endif
> 
>diff -ur mozilla.orig/widget/src/xremoteclient/XRemoteClient.cpp mozilla/widget/src/xremoteclient/XRemoteClient.cpp
>--- mozilla.orig/widget/src/xremoteclient/XRemoteClient.cpp	2006-03-30 10:01:13.000000000 +0200
>+++ mozilla/widget/src/xremoteclient/XRemoteClient.cpp	2007-12-30 19:23:26.000000000 +0100
>@@ -76,7 +76,8 @@
> #endif
>     
> #ifndef MAX_PATH
>-#define MAX_PATH 1024
>+#include <limits.h>
>+#define MAX_PATH PATH_MAX
> #endif
> 
> #define ARRAY_LENGTH(array_) (sizeof(array_)/sizeof(array_[0]))
>diff -ur mozilla.orig/xpcom/build/nsXPCOMPrivate.h mozilla/xpcom/build/nsXPCOMPrivate.h
>--- mozilla.orig/xpcom/build/nsXPCOMPrivate.h	2006-01-09 20:03:09.000000000 +0100
>+++ mozilla/xpcom/build/nsXPCOMPrivate.h	2007-12-30 19:23:26.000000000 +0100
>@@ -252,7 +252,8 @@
> #elif defined(CCHMAXPATH)
> #define MAXPATHLEN CCHMAXPATH
> #else
>-#define MAXPATHLEN 1024
>+#include <limits.h>
>+#define MAXPATHLEN PATH_MAX
> #endif
> #endif
> 
>diff -ur mozilla.orig/xpcom/io/SpecialSystemDirectory.cpp mozilla/xpcom/io/SpecialSystemDirectory.cpp
>--- mozilla.orig/xpcom/io/SpecialSystemDirectory.cpp	2007-09-06 23:44:29.000000000 +0200
>+++ mozilla/xpcom/io/SpecialSystemDirectory.cpp	2007-12-30 19:23:26.000000000 +0100
>@@ -109,7 +109,8 @@
> #elif defined(CCHMAXPATH)
> #define MAXPATHLEN CCHMAXPATH
> #else
>-#define MAXPATHLEN 1024
>+#include <limits.h>
>+#define MAXPATHLEN PATH_MAX
> #endif
> #endif
> 
>diff -ur mozilla.orig/xpcom/obsolete/nsFileSpecUnix.cpp mozilla/xpcom/obsolete/nsFileSpecUnix.cpp
>--- mozilla.orig/xpcom/obsolete/nsFileSpecUnix.cpp	2006-11-28 01:18:37.000000000 +0100
>+++ mozilla/xpcom/obsolete/nsFileSpecUnix.cpp	2007-12-30 19:23:26.000000000 +0100
>@@ -79,7 +79,8 @@
> #endif
> 
> #ifndef MAXPATHLEN
>-#define MAXPATHLEN	1024  /* Guessing this is okay.  Works for SCO. */
>+#include <limits.h>
>+#define MAXPATHLEN	PATH_MAX  /* Guessing this is okay.  Works for SCO. */
> #endif
>  
> #if defined(__QNX__)
>diff -ur mozilla.orig/xpcom/typelib/xpidl/xpidl_java.c mozilla/xpcom/typelib/xpidl/xpidl_java.c
>--- mozilla.orig/xpcom/typelib/xpidl/xpidl_java.c	2007-08-31 06:20:17.000000000 +0200
>+++ mozilla/xpcom/typelib/xpidl/xpidl_java.c	2007-12-30 19:23:26.000000000 +0100
>@@ -44,6 +44,7 @@
> #include "xpidl.h"
> #include <ctype.h>
> #include <glib.h>
>+#include <limits.h>
> 
> #ifdef XP_WIN
> #include <windef.h>

Actions: View | Diff

Attachments on bug 357661: 290555