Attachment 290635 Details for Bug 426578 – proposed patch from Roger Kumpf

[patch] proposed patch from Roger Kumpf

cve-2008-0003.patch (text/plain), 2.62 KB, created by Mark J. Cox on 2008-01-02 08:55:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark J. Cox

Created: 2008-01-02 08:55:30 UTC

Size: 2.62 KB

patch

obsolete

>Index: pegasus/src/Pegasus/Security/Authentication/PAMBasicAuthenticatorUnix.cpp
>===================================================================
>RCS file: /cvs/MSB/pegasus/src/Pegasus/Security/Authentication/PAMBasicAuthenticatorUnix.cpp,v
>retrieving revision 1.34.4.1
>diff -u -r1.34.4.1 PAMBasicAuthenticatorUnix.cpp
>--- pegasus/src/Pegasus/Security/Authentication/PAMBasicAuthenticatorUnix.cpp	4 Apr 2007 11:04:52 -0000	1.34.4.1
>+++ pegasus/src/Pegasus/Security/Authentication/PAMBasicAuthenticatorUnix.cpp	31 Dec 2007 18:31:24 -0000
>@@ -38,6 +38,8 @@
> //
> //%/////////////////////////////////////////////////////////////////////////////
> 
>+// NOCHKSRC
>+
> #include <Pegasus/Common/System.h>
> #include <Pegasus/Common/Tracer.h>
> #include <Pegasus/Config/ConfigManager.h>
>@@ -387,7 +389,8 @@
>                 // copy the user password
>                 // 
>                 resp[i]->resp = (char *)malloc(PAM_MAX_MSG_SIZE);
>-                strcpy(resp[i]->resp, mydata->userPassword);
>+                strncpy(resp[i]->resp, mydata->userPassword, PAM_MAX_MSG_SIZE);
>+                resp[i]->resp[PAM_MAX_MSG_SIZE - 1] = 0;
>                 resp[i]->resp_retcode = 0;
>                 break;
> 
>Index: pegasus/src/Pegasus/Security/Cimservera/cimservera.cpp
>===================================================================
>RCS file: /cvs/MSB/pegasus/src/Pegasus/Security/Cimservera/Attic/cimservera.cpp,v
>retrieving revision 1.6
>diff -u -r1.6 cimservera.cpp
>--- pegasus/src/Pegasus/Security/Cimservera/cimservera.cpp	30 Jan 2006 16:18:29 -0000	1.6
>+++ pegasus/src/Pegasus/Security/Cimservera/cimservera.cpp	31 Dec 2007 18:31:24 -0000
>@@ -29,14 +29,10 @@
> //
> //==============================================================================
> //
>-// Author: Ben Heilbronn, Hewlett-Packard Company(ben_heilbronn@hp.com)
>-//
>-//         Parts of this code originated within PAMBasicAuthenticator.
>-//
>-// Modified By: Sushma Fernandes, Hewlett-Packard Company(sushma_fernandes@hp.com)
>-//
> //%/////////////////////////////////////////////////////////////////////////////
> 
>+// NOCHKSRC
>+
> #include <Pegasus/Common/System.h>
> #include <Pegasus/Common/String.h>
> #include <Pegasus/Common/FileSystem.h>
>@@ -185,7 +181,8 @@
>                 // copy the user password
>                 // 
>                 resp[i]->resp = (char *)malloc(PAM_MAX_MSG_SIZE);
>-                strcpy(resp[i]->resp, mydata->userPassword);
>+                strncpy(resp[i]->resp, mydata->userPassword, PAM_MAX_MSG_SIZE);
>+                resp[i]->resp[PAM_MAX_MSG_SIZE - 1] = 0;
>                 resp[i]->resp_retcode = 0;
>                 break;
>

Actions: View | Diff

Attachments on bug 426578: 290635