Attachment 290768 Details for Bug 251225 – Unlink kernel/initrd after running bootloader in dryrun mode

[patch] Unlink kernel/initrd after running bootloader in dryrun mode

xen-pygrub-dryrun.patch (text/plain), 1.01 KB, created by Daniel Berrangé on 2008-01-03 19:42:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Berrangé

Created: 2008-01-03 19:42:35 UTC

Size: 1.01 KB

patch

obsolete

>xm create -n runs the bootloader to figure out the configuration.  It
>doesn't clean up afterwards: kernel and ramdisk are left behind in
>/var/lib/xen/
>
>xen-unstable doesn't have this problem, but that's of no help, as the
>code has been warped beyond recognition.
>
>The patch is a straightforward, if somewhat ham-fisted fix.  Bug
>251225.  Please ACK.
>
>--- a/tools/python/xen/xm/create.py	2007-11-26 17:37:06.000000000 +0100
>+++ b/tools/python/xen/xm/create.py	2007-12-10 20:28:12.000000000 +0100
>@@ -758,6 +758,12 @@ def make_config(vals):
>     config_image = configure_image(vals)
>     if vals.bootloader:
>         config_image = run_bootloader(vals, config_image)
>+        if vals.dryrun:
>+            try:
>+                os.unlink(sxp.child_value(config_image, 'ramdisk'))
>+                os.unlink(sxp.child_value(config_image, 'kernel'))
>+            except:
>+                pass
>         config.append(['bootloader', vals.bootloader])
>         if vals.bootargs:
>             config.append(['bootloader_args', vals.bootargs])
>

Actions: View | Diff

Attachments on bug 251225: 160855 | 160856 | 160857 | 290768