Attachment 291174 Details for Bug 417051 – Escape quotes in disk paths

[patch] Escape quotes in disk paths

virtinst-escaping.patch (text/plain), 1.05 KB, created by Daniel Berrangé on 2008-01-09 17:48:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Berrangé

Created: 2008-01-09 17:48:34 UTC

Size: 1.05 KB

patch

obsolete

>changeset:   332:5dcf3867811a
>tag:         tip
>user:        "Daniel P. Berrange <berrange@redhat.com>"
>date:        Mon Jan 07 09:56:21 2008 -0500
>files:       tests/misc-xml-escaping.xml tests/xmlconfig.py virtinst/Guest.py
>description:
>Escape disk image paths
>
>
>diff -r 5486afdf6a01 -r 5dcf3867811a virtinst/Guest.py
>--- a/virtinst/Guest.py	Wed Jan 02 13:41:41 2008 -0500
>+++ b/virtinst/Guest.py	Mon Jan 07 09:56:21 2008 -0500
>@@ -180,7 +180,8 @@ class VirtualDisk:
>             else:
>                 ret += "      <driver name='%(name)s' type='%(type)s'/>\n" % { "name": self.driver_name, "type": self.driver_type }
>         if self.path is not None:
>-            ret += "      <source %(typeattr)s='%(disk)s'/>\n" % { "typeattr": typeattr, "disk": self.path }
>+            path = self.path.replace("'", "&apos;")
>+            ret += "      <source %(typeattr)s='%(disk)s'/>\n" % { "typeattr": typeattr, "disk": path }
>         if self.target is not None:
>             disknode = self.target
>         ret += "      <target dev='%(disknode)s'/>\n" % { "disknode": disknode }
>

Actions: View | Diff

Attachments on bug 417051: 291174 | 291175