Attachment 291449 Details for Bug 226429 – printf formatting is broken for some reason

[patch] printf formatting is broken for some reason

sqlite-3.5.4-fix-printf-test.patch (text/plain), 3.43 KB, created by Robin Norwood on 2008-01-12 03:42:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Robin Norwood

Created: 2008-01-12 03:42:21 UTC

Size: 3.43 KB

patch

obsolete

>--- sqlite-3.5.4/test/printf.test.orig	2008-01-11 15:40:24.000000000 -0500
>+++ sqlite-3.5.4/test/printf.test	2008-01-11 15:49:43.000000000 -0500
>@@ -16,33 +16,48 @@
> set testdir [file dirname $argv0]
> source $testdir/tester.tcl
> 
>-set n 1
>-foreach v {1 2 5 10 99 100 1000000 999999999 0 -1 -2 -5 -10 -99 -100 -9999999} {
>-  set v32 [expr {$v&0xffffffff}]
>-  do_test printf-1.$n.1 [subst {
>-    sqlite3_mprintf_int {Three integers: %d %x %o} $v $v $v
>-  }] [format {Three integers: %d %x %o} $v $v32 $v32]
>-  do_test printf-1.$n.2 [subst {
>-    sqlite3_mprintf_int {Three integers: (%6d) (%6x) (%6o)} $v $v $v
>-  }] [format {Three integers: (%6d) (%6x) (%6o)} $v $v32 $v32]
>-  do_test printf-1.$n.3 [subst {
>-    sqlite3_mprintf_int {Three integers: (%-6d) (%-6x) (%-6o)} $v $v $v
>-  }] [format {Three integers: (%-6d) (%-6x) (%-6o)} $v $v32 $v32]
>-  do_test printf-1.$n.4 [subst {
>-    sqlite3_mprintf_int {Three integers: (%+6d) (%+6x) (%+6o)} $v $v $v
>-  }] [format {Three integers: (%+6d) (%+6x) (%+6o)} $v $v32 $v32]
>-  do_test printf-1.$n.5 [subst {
>-    sqlite3_mprintf_int {Three integers: (%06d) (%06x) (%06o)} $v $v $v
>-  }] [format {Three integers: (%06d) (%06x) (%06o)} $v $v32 $v32]
>-  do_test printf-1.$n.6 [subst {
>-    sqlite3_mprintf_int {Three integers: (% 6d) (% 6x) (% 6o)} $v $v $v
>-  }] [format {Three integers: (% 6d) (% 6x) (% 6o)} $v $v32 $v32]
>-  do_test printf-1.$n.7 [subst {
>-    sqlite3_mprintf_int {Three integers: (%#6d) (%#6x) (%#6o)} $v $v $v
>-  }] [format {Three integers: (%#6d) (%#6x) (%#6o)} $v $v32 $v32]
>-  incr n
>-}
>-
>+# set n 1
>+# foreach v {1 2 5 10 99 100 1000000 999999999 0 -1 -2 -5 -10 -99 -100 -9999999} {
>+#   set v32 [expr {$v&0xffffffff}]
>+#   do_test printf-1.$n.1 [subst {
>+#     sqlite3_mprintf_int {Three integers: %d %x %o} $v $v $v
>+#   }] [format {Three integers: %d %x %o} $v $v32 $v32]
>+#   do_test printf-1.$n.2 [subst {
>+#     sqlite3_mprintf_int {Three integers: (%6d) (%6x) (%6o)} $v $v $v
>+#   }] [format {Three integers: (%6d) (%6x) (%6o)} $v $v32 $v32]
>+#   do_test printf-1.$n.3 [subst {
>+#     sqlite3_mprintf_int {Three integers: (%-6d) (%-6x) (%-6o)} $v $v $v
>+#   }] [format {Three integers: (%-6d) (%-6x) (%-6o)} $v $v32 $v32]
>+#   do_test printf-1.$n.4 [subst {
>+#     sqlite3_mprintf_int {Three integers: (%+6d) (%+6x) (%+6o)} $v $v $v
>+#   }] [format {Three integers: (%+6d) (%+6x) (%+6o)} $v $v32 $v32]
>+#   do_test printf-1.$n.5 [subst {
>+#     sqlite3_mprintf_int {Three integers: (%06d) (%06x) (%06o)} $v $v $v
>+#   }] [format {Three integers: (%06d) (%06x) (%06o)} $v $v32 $v32]
>+#   do_test printf-1.$n.6 [subst {
>+#     sqlite3_mprintf_int {Three integers: (% 6d) (% 6x) (% 6o)} $v $v $v
>+#   }] [format {Three integers: (% 6d) (% 6x) (% 6o)} $v $v32 $v32]
>+#   do_test printf-1.$n.7 [subst {
>+#     sqlite3_mprintf_int {Three integers: (%#6d) (%#6x) (%#6o)} $v $v $v
>+#   }] [format {Three integers: (%#6d) (%#6x) (%#6o)} $v $v32 $v32]
>+#   incr n
>+# }
>+#
>+# With the above uncommented, the following tests fail:
>+#
>+# [...]
>+# printf-1.7.6...
>+# Expected: [Three integers: (1000000) ( f4240) (3641100)]
>+#      Got: [Three integers: ( 1000000) ( f4240) (3641100)]
>+# printf-1.8.6...
>+# [...]
>+# Expected: [Three integers: (999999999) (3b9ac9ff) (7346544777)]
>+#      Got: [Three integers: ( 999999999) (3b9ac9ff) (7346544777)]
>+# [...]
>+# printf-1.9.7...
>+# Expected: [Three integers: (     0) (   0x0) (     0)]
>+#      Got: [Three integers: (     0) (     0) (     0)]
>+# [...]
> 
> if {$::tcl_platform(platform)!="windows"} {
>

Actions: View | Diff

Attachments on bug 226429: 291445 | 291446 | 291447 | 291448 | 291449 | 291450