Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 291998 Details for
Bug 428586
Review Request: ldm - LTSP Display Manager
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Fix many warnings issued by gcc.
ldm-gcc-warnings.patch (text/plain), 3.28 KB, created by
Toshio Ernie Kuratomi
on 2008-01-17 14:25:04 UTC
(
hide
)
Description:
Fix many warnings issued by gcc.
Filename:
MIME Type:
Creator:
Toshio Ernie Kuratomi
Created:
2008-01-17 14:25:04 UTC
Size:
3.28 KB
patch
obsolete
>=== modified file 'gtkgreet/greeter.c' >--- gtkgreet/greeter.c 2007-11-05 00:20:24 +0000 >+++ gtkgreet/greeter.c 2008-01-17 14:17:30 +0000 >@@ -38,14 +38,14 @@ > static void > halt(GtkWidget * widget, gpointer data) > { >- GError **error; >+ GError **error = NULL; > g_spawn_command_line_async("/sbin/poweroff -fp", error); > } > > static void > reboot(GtkWidget * widget, gpointer data) > { >- GError **error; >+ GError **error = NULL; > g_spawn_command_line_async("/sbin/reboot -fp", error); > } > > >=== modified file 'gtkgreet/hostwin.c' >--- gtkgreet/hostwin.c 2007-11-05 00:20:24 +0000 >+++ gtkgreet/hostwin.c 2008-01-17 14:15:23 +0000 >@@ -68,8 +68,6 @@ > { > GtkWidget *hostwin, *label, *vbox, *buttonbox, *combo_host; > GtkWidget *cancel, *accept, *frame; >- GtkListStore *list_store; >- GtkTreeIter iter; > > hostwin = gtk_window_new(GTK_WINDOW_POPUP); > gtk_window_set_position((GtkWindow *) hostwin, > >=== modified file 'src/get_ip.c' >--- src/get_ip.c 2007-08-18 03:59:04 +0000 >+++ src/get_ip.c 2008-01-17 14:13:54 +0000 >@@ -17,6 +17,7 @@ > #include <syslog.h> > #include <string.h> > #include <stdio.h> >+#include <stdlib.h> > #include <glib.h> > > #include "ldm.h" >@@ -30,9 +31,7 @@ > struct ifreq info; > struct sockaddr_in *sa; > >- char *ipaddr = NULL; >- >- int skfd, n; >+ int skfd, n = 0; > > skfd = socket(PF_INET, SOCK_DGRAM, IPPROTO_IP); > if (skfd < 0) > >=== modified file 'src/greeter_iface.c' >--- src/greeter_iface.c 2007-08-18 03:59:04 +0000 >+++ src/greeter_iface.c 2008-01-17 14:07:58 +0000 >@@ -79,7 +79,7 @@ > char *p; > > fprintf(ldmlog, "In get_userid\n"); >- if (p = getenv("LDM_USERNAME")) { >+ if ((p = getenv("LDM_USERNAME"))) { > scopy(ldminfo.username, p); > return 0; > } else { >@@ -100,7 +100,7 @@ > char *p; > > fprintf(ldmlog, "In get_passwd\n"); >- if (p = getenv("LDM_PASSWORD")) { >+ if ((p = getenv("LDM_PASSWORD"))) { > scopy(ldminfo.password, p); > return 0; > } else { >@@ -115,10 +115,8 @@ > void > set_message(char *message) > { >- char password[255]; > char *prompt = "msg "; > char *pw = "\n"; >- char *p; > > write(ldminfo.greeterwfd, prompt, strlen(prompt)); > write(ldminfo.greeterwfd, message, strlen(message)); > >=== modified file 'src/ldm.c' >--- src/ldm.c 2008-01-15 17:26:13 +0000 >+++ src/ldm.c 2008-01-17 13:56:21 +0000 >@@ -20,6 +20,7 @@ > #include <sys/wait.h> > #include <glib.h> > #include <glib/gi18n.h> >+#include <glib-object.h> > > #include "ldm.h" > > >=== modified file 'src/ldm.h' >--- src/ldm.h 2007-08-18 03:59:04 +0000 >+++ src/ldm.h 2008-01-17 14:08:46 +0000 >@@ -31,6 +31,7 @@ > > void usage(); > void die(char *msg); >+void dump_cmdline(char *argv[]); > int ldm_getenv_bool(const char *name); > pid_t ldm_spawn (char **argv); > char *scopy(char *dest, char *source); >@@ -45,6 +46,12 @@ > void get_ipaddr(); > void clean_username(); > void clean_password(); >+void spawn_greeter(); >+int get_host(); >+int get_language(); >+int get_session(); >+void set_message(char *message); >+void close_greeter(); > > extern struct ldm_info ldminfo; > extern FILE *ldmlog; > >=== modified file 'src/sshutils.c' >--- src/sshutils.c 2007-09-03 02:19:26 +0000 >+++ src/sshutils.c 2008-01-17 14:11:00 +0000 >@@ -280,6 +280,7 @@ > close(fd_master); /* child */ > spawn_ssh(fd_slave); > } >+ return 0; > } > > int >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 428586
:
291708
| 291998