Attachment 294076 Details for Bug 406471 – the other possible way we can do OR based group checking in User.pm file

[patch] the other possible way we can do OR based group checking in User.pm file

patch.diff (text/plain), 2.49 KB, created by Tony Fu on 2008-02-06 06:51:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tony Fu

Created: 2008-02-06 06:51:18 UTC

Size: 2.49 KB

patch

obsolete

>Index: User.pm
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/Bugzilla/User.pm,v
>retrieving revision 1.3
>diff -u -r1.3 User.pm
>--- User.pm	20 Jan 2008 16:38:25 -0000	1.3
>+++ User.pm	6 Feb 2008 06:45:28 -0000
>@@ -584,6 +584,27 @@
>     # is cached because this may be called for every row in buglists or
>     # every bug in a dependency list.
>     unless ($sth) {
>+	# REDHAT EXTENSION START 406471
>+	# OR based group checking
>+	if (Bugzilla->params->{'or_groups'}) {
>+        	$sth = $dbh->prepare("SELECT 1, reporter, assigned_to, qa_contact,
>+                             reporter_accessible, cclist_accessible,
>+                             COUNT(cc.who), COUNT(user_group_map.group_id)
>+                             FROM bugs
>+                             LEFT JOIN cc 
>+                               ON cc.bug_id = bugs.bug_id
>+                               AND cc.who = $userid
>+                             LEFT JOIN bug_group_map 
>+                               ON bugs.bug_id = bug_group_map.bug_id
>+			     LEFT JOIN user_group_map
>+			       ON bug_group_map.group_id = user_group_map.group_id
>+                            WHERE bugs.bug_id = ? 
>+                               AND creation_ts IS NOT NULL " .
>+                             $dbh->sql_group_by('bugs.bug_id', 'reporter, ' .
>+                             'assigned_to, qa_contact, reporter_accessible, ' .
>+                             'cclist_accessible'));
>+	} else {
>+	# REDHAT EXTENSION END 406471
>         $sth = $dbh->prepare("SELECT 1, reporter, assigned_to, qa_contact,
>                              reporter_accessible, cclist_accessible,
>                              COUNT(cc.who), COUNT(bug_group_map.bug_id)
>@@ -600,12 +621,19 @@
>                              $dbh->sql_group_by('bugs.bug_id', 'reporter, ' .
>                              'assigned_to, qa_contact, reporter_accessible, ' .
>                              'cclist_accessible'));
>+	  }
>     }
>     $sth->execute($bugid);
>     my ($ready, $reporter, $owner, $qacontact, $reporter_access, $cclist_access,
>         $isoncclist, $missinggroup) = $sth->fetchrow_array();
>     $sth->finish;
>     $self->{sthCanSeeBug} = $sth;
>+    # REDHAT EXTENSION START 406471
>+    # OR based group checking
>+    if (Bugzilla->params->{'or_groups'}) {
>+	$missinggroup = !$missinggroup;
>+    }
>+    # REDHAT EXTENSION END 406471
>     return ($ready
>             && ((($reporter == $userid) && $reporter_access)
>                 || (Bugzilla->params->{'useqacontact'}

Actions: View | Diff

Attachments on bug 406471: 293982 | 293983 | 293984 | 294053 | 294073 | 294075 | 294076 | 294190 | 294306 | 294480 | 294619 | 294629 | 294714 | 294715 | 294863 | 294968 | 298956