Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 294195 Details for
Bug 431840
fhpd message injection during a buffer flush can cause corrupt or incomplete message buffer
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Synchronize buffer access patch
messages.patch (text/plain), 2.11 KB, created by
Phil Muldoon
on 2008-02-07 09:37:06 UTC
(
hide
)
Description:
Synchronize buffer access patch
Filename:
MIME Type:
Creator:
Phil Muldoon
Created:
2008-02-07 09:37:06 UTC
Size:
2.11 KB
patch
obsolete
>diff --git a/frysk-core/frysk/hpd/CLI.java b/frysk-core/frysk/hpd/CLI.java >index c08fb3d..61f5033 100644 >--- a/frysk-core/frysk/hpd/CLI.java >+++ b/frysk-core/frysk/hpd/CLI.java >@@ -313,7 +313,9 @@ public class CLI { > } > > void addMessage(Message msg) { >- messages.add(msg); >+ synchronized (messages) { >+ messages.add(msg); >+ } > } > > void addMessage(String msg, int type) { >@@ -321,20 +323,22 @@ public class CLI { > } > > private void flushMessages() { >- for (Iterator iter = messages.iterator(); iter.hasNext();) { >- Message tempmsg = (Message) iter.next(); >- String prefix = null; >- if (tempmsg.getType() == Message.TYPE_DBG_ERROR) >- prefix = "Internal debugger error: "; >- else if (tempmsg.getType() == Message.TYPE_ERROR) >- prefix = "Error: "; >- else if (tempmsg.getType() == Message.TYPE_WARNING) >- prefix = "Warning: "; >- if (prefix != null) >- outWriter.print(prefix); >- outWriter.println(tempmsg.getMessage()); >- iter.remove(); >- } >+ synchronized (messages) { >+ for (Iterator iter = messages.iterator(); iter.hasNext();) { >+ Message tempmsg = (Message) iter.next(); >+ String prefix = null; >+ if (tempmsg.getType() == Message.TYPE_DBG_ERROR) >+ prefix = "Internal debugger error: "; >+ else if (tempmsg.getType() == Message.TYPE_ERROR) >+ prefix = "Error: "; >+ else if (tempmsg.getType() == Message.TYPE_WARNING) >+ prefix = "Warning: "; >+ if (prefix != null) >+ outWriter.print(prefix); >+ outWriter.println(tempmsg.getMessage()); >+ iter.remove(); >+ } >+ } > } > > PTSet createSet(String set) { >diff --git a/frysk-core/frysk/hpd/ChangeLog b/frysk-core/frysk/hpd/ChangeLog >index cb14df0..ba4301b 100644 >--- a/frysk-core/frysk/hpd/ChangeLog >+++ b/frysk-core/frysk/hpd/ChangeLog >@@ -1,3 +1,8 @@ >+2008-02-06 Phil Muldoon <pmuldoon@redhat.com> >+ >+ * CLI.java (addMessage): Synchronize on message. >+ (flushMessages): Ditto. >+ > 2008-02-05 Andrew Cagney <cagney@redhat.com> > > * GenerateCoreCommand.java: Update; corefiles moved to
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 431840
: 294195