Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 294608 Details for
Bug 432419
CVE-2008-0595 dbus security policy circumvention
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Proposed patch
dbus-fix.patch (text/plain), 2.19 KB, created by
Josh Bressers
on 2008-02-12 00:16:55 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Josh Bressers
Created:
2008-02-12 00:16:55 UTC
Size:
2.19 KB
patch
obsolete
>diff --git a/bus/policy.c b/bus/policy.c >index 383b2b1..caa544e 100644 >--- a/bus/policy.c >+++ b/bus/policy.c >@@ -942,9 +942,19 @@ bus_client_policy_check_can_send (BusClientPolicy *policy, > > if (rule->d.send.interface != NULL) > { >- if (dbus_message_get_interface (message) != NULL && >- strcmp (dbus_message_get_interface (message), >- rule->d.send.interface) != 0) >+ /* The interface is optional in messages. For allow rules, if the message >+ * has no interface we want to skip the rule (and thus not allow); >+ * for deny rules, if the message has no interface we want to use the >+ * rule (and thus deny). >+ */ >+ dbus_bool_t no_interface; >+ >+ no_interface = dbus_message_get_interface (message) == NULL; >+ >+ if ((no_interface && rule->allow) || >+ (!no_interface && >+ strcmp (dbus_message_get_interface (message), >+ rule->d.send.interface) != 0)) > { > _dbus_verbose (" (policy) skipping rule for different interface\n"); > continue; >@@ -1128,9 +1138,19 @@ bus_client_policy_check_can_receive (BusClientPolicy *policy, > > if (rule->d.receive.interface != NULL) > { >- if (dbus_message_get_interface (message) != NULL && >- strcmp (dbus_message_get_interface (message), >- rule->d.receive.interface) != 0) >+ /* The interface is optional in messages. For allow rules, if the message >+ * has no interface we want to skip the rule (and thus not allow); >+ * for deny rules, if the message has no interface we want to use the >+ * rule (and thus deny). >+ */ >+ dbus_bool_t no_interface; >+ >+ no_interface = dbus_message_get_interface (message) == NULL; >+ >+ if ((no_interface && rule->allow) || >+ (!no_interface && >+ strcmp (dbus_message_get_interface (message), >+ rule->d.receive.interface) != 0)) > { > _dbus_verbose (" (policy) skipping rule for different interface\n"); > continue;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 432419
: 294608