Attachment 294619 Details for Bug 406471 – OR based group checking in can_edit_products function

[patch] OR based group checking in can_edit_products function

patch.diff (text/plain), 1.63 KB, created by Tony Fu on 2008-02-12 02:38:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tony Fu

Created: 2008-02-12 02:38:06 UTC

Size: 1.63 KB

patch

obsolete

>Index: User.pm
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/Bugzilla/User.pm,v
>retrieving revision 1.3
>diff -u -r1.3 User.pm
>--- User.pm	20 Jan 2008 16:38:25 -0000	1.3
>+++ User.pm	12 Feb 2008 02:31:24 -0000
>@@ -563,13 +563,31 @@
>     my ($self, $prod_id) = @_;
>     my $dbh = Bugzilla->dbh;
> 
>-    my $has_external_groups =
>-      $dbh->selectrow_array('SELECT 1
>+    # REDHAT EXTENSION START 406471
>+    my $has_external_groups;
>+    # OR based group checking
>+    if ( Bugzilla->params->{'or_groups'} ) {
>+        my $or_group_check = 
>+          $dbh->selectrow_array('SELECT 1 
>+                                 FROM group_control_map
>+                            LEFT JOIN user_group_map
>+                                   ON group_control_map.group_id = user_group_map.group_id
>+                                  AND product_id = ?
>+                                WHERE (group_control_map.group_id IS NULL )
>+                                   OR (canedit != 0
>+                                  AND user_group_map.group_id IS NOT NULL)',
>+                                undef, $prod_id);
>+       $has_external_groups = !$or_group_check; 
>+    # REDHAT EXTENSION END 406471
>+    } else {
>+        $has_external_groups =
>+        $dbh->selectrow_array('SELECT 1
>                                FROM group_control_map
>                               WHERE product_id = ?
>                                 AND canedit != 0
>                                 AND group_id NOT IN(' . $self->groups_as_string . ')',
>                              undef, $prod_id);
>+      }
> 
>     return !$has_external_groups;
> }

Actions: View | Diff

Attachments on bug 406471: 293982 | 293983 | 293984 | 294053 | 294073 | 294075 | 294076 | 294190 | 294306 | 294480 | 294619 | 294629 | 294714 | 294715 | 294863 | 294968 | 298956