Attachment 294756 Details for Bug 406371 – Update colchange.cgi and buglist.cgi to show additional columns

[patch] Update colchange.cgi and buglist.cgi to show additional columns

patch.diff (text/plain), 5.69 KB, created by Tony Fu on 2008-02-13 06:50:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tony Fu

Created: 2008-02-13 06:50:27 UTC

Size: 5.69 KB

patch

obsolete

>Index: Bugzilla/DB/Mysql.pm
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/Bugzilla/DB/Mysql.pm,v
>retrieving revision 1.3
>diff -u -r1.3 Mysql.pm
>--- Bugzilla/DB/Mysql.pm    28 Jan 2008 04:46:17 -0000  1.3
>+++ Bugzilla/DB/Mysql.pm    13 Feb 2008 04:28:21 -0000
>@@ -205,6 +205,28 @@
>     return $self->_bz_build_schema_from_disk();
> }
> 
>+# REDHAT EXTENSION START 406371
>+sub sql_issue_tracker_list {
>+    my ($self) = @_;
>+    return "IssueTrackerList(bugs.bug_id)";
>+}
>+
>+sub sql_flag_list {
>+    my ($self, @group_ids) = @_;
>+    return "FLagList(bugs.bug_id,'" . join(',', @group_ids). "')";
>+}
>+
>+sub sql_dependson_list {
>+    my ($self) = @_;
>+    return "DependsOnList(bugs.bug_id)";
>+}
>+
>+sub sql_blockedby_list {
>+    my ($self) = @_;
>+    return "BlockedByList(bugs.bug_id)";
>+}
>+# REDHAT EXTENSION END 406371
>+
> #####################################################################
> # Database Setup
> #####################################################################
>Index: Bugzilla/DB/Pg.pm
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/Bugzilla/DB/Pg.pm,v
>retrieving revision 1.3
>diff -u -r1.3 Pg.pm
>--- Bugzilla/DB/Pg.pm   19 Dec 2007 16:20:04 -0000  1.3
>+++ Bugzilla/DB/Pg.pm   13 Feb 2008 04:28:21 -0000
>@@ -167,6 +167,35 @@
>     return $exists || 0;
> }
> 
>+# REDHAT EXTENSION START 406371
>+sub sql_issue_tracker_list {
>+    my ($self) = @_;
>+    return "ARRAY(SELECT it_id FROM bz_it_map WHERE bz_id = bugs.bug_id AND it_id IS NOT NULL)";
>+}
>+
>+sub sql_flag_list {
>+    my ($self, @group_ids) = @_;
>+    my $flag_select = "ARRAY(SELECT flagtypes.name || flags.status FROM flags 
>+                       LEFT JOIN flagtypes ON flags.type_id = flagtypes.id 
>+                       WHERE flags.is_active = 1 AND (flagtypes.view_group_id IS NULL";
>+    if ( $group_ids_string ) {
>+        $flag_select .= " OR flagtypes.view_group_id IN (" . join(',', @group_ids) . ")";
>+    }
>+    $flag_select .= ") AND flags.bug_id = bugs.bug_id)";
>+    return $flag_select;
>+}
>+
>+sub sql_dependson_list {
>+    my ($self) = @_;
>+    return "ARRAY(SELECT dependson FROM dependencies WHERE blocked = bugs.bug_id)";
>+}
>+
>+sub sql_blockedby_list {
>+    my ($self) = @_;
>+    return "ARRAY(SELECT blocked FROM dependencies WHERE dependson = bugs.bug_id)";
>+}
>+# REDHAT EXTENSION END 406371
>+
> #####################################################################
> # Custom Database Setup
> #####################################################################
>Index: buglist.cgi
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/buglist.cgi,v
>retrieving revision 1.3
>diff -u -r1.3 buglist.cgi
>--- buglist.cgi	20 Jan 2008 16:37:08 -0000	1.3
>+++ buglist.cgi	13 Feb 2008 05:46:04 -0000
>@@ -671,6 +671,16 @@
>     "END) AS percentage_complete"                               , "% Complete"); 
> DefineColumn("relevance"         , "relevance"                  , "Relevance"        );
> DefineColumn("deadline"          , $dbh->sql_date_format('bugs.deadline', '%Y-%m-%d') . " AS deadline", "Deadline");
>+# REDHAT EXTENSION START 406371
>+DefineColumn("devel_whiteboard"   , "bugs.devel_whiteboard"     , "Devel Summary"        );
>+DefineColumn("qa_whiteboard"   , "bugs.qa_whiteboard"     , "QA Status Summary"        );
>+DefineColumn("internal_whiteboard" , "bugs.internal_whiteboard" , "Internal Summary"        );
>+DefineColumn("issuetrackers"     , $dbh->sql_issue_tracker_list(values(%{Bugzilla->user->groups})) . " AS issuetrackers", "Issue Trackers");
>+DefineColumn("dependson"         , $dbh->sql_dependson_list(values(%{Bugzilla->user->groups})) . " AS dependson", "Depends On");
>+DefineColumn("blockedby"         , $dbh->sql_blockedby_list(values(%{Bugzilla->user->groups})) . " AS blockedby", "Blocked By");
>+DefineColumn("itmaxscore"        , "(SELECT max(it_score) FROM bz_it_map WHERE bz_id = bugs.bug_id) AS itmaxscore", "IT Max Score");
>+DefineColumn("flags"             , $dbh->sql_flag_list(values(%{Bugzilla->user->groups})) . " AS flags", "Flags" );
>+# REDHAT EXTENSION END 406371
> 
> foreach my $field (Bugzilla->get_fields({ custom => 1, obsolete => 0})) {
>     DefineColumn($field->name, 'bugs.' . $field->name, $field->description);
>Index: colchange.cgi
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/colchange.cgi,v
>retrieving revision 1.1.1.1
>diff -u -r1.1.1.1 colchange.cgi
>--- colchange.cgi	19 Nov 2007 22:11:21 -0000	1.1.1.1
>+++ colchange.cgi	13 Feb 2008 05:46:19 -0000
>@@ -56,6 +56,10 @@
> if (Bugzilla->params->{"usevotes"}) {
>     push (@masterlist, "votes");
> }
>+# REDHAT EXTENSION START 406371
>+push(@masterlist, ("dependson", "blockedby", "flags"));
>+# REDHAT EXTENSION END 406371
>+
> if (Bugzilla->params->{"usebugaliases"}) {
>     unshift(@masterlist, "alias");
> }
>@@ -77,7 +81,25 @@
>     push(@masterlist, ("estimated_time", "remaining_time", "actual_time",
>                        "percentage_complete", "deadline")); 
> }
>-
>+# REDHAT EXTENSION START 406371
>+if (Bugzilla->user->in_group('qa_whiteboard')) {
>+    push(@masterlist, "qa_whiteboard");
>+}
>+if (Bugzilla->user->in_group('devel')) {
>+    push(@masterlist, "devel_whiteboard");
>+}
>+if (Bugzilla->user->in_group('internalwhiteboard')) {
>+    push(@masterlist, "internal_whiteboard");
>+}
>+if (Bugzilla->user->in_group('rhn')) {
>+    push(@masterlist, "cust_facing");
>+}
>+if (Bugzilla->params->{"useissuetracker"} && Bugzilla->user->in_group('issuetracker')) {
>+    push(@masterlist, "cust_facing");
>+    push(@masterlist, "issuetrackers");
>+    push(@masterlist, "itmaxscore");
>+}
>+# REDHAT EXTENSION END 406371
> push(@masterlist, ("short_desc", "short_short_desc"));
> 
> my @custom_fields = grep { $_->type != FIELD_TYPE_MULTI_SELECT }

Actions: View | Diff

Attachments on bug 406371: 294729 | 294756 | 294892