Attachment 295941 Details for Bug 433509 – Don't log passwords in ipaserver-install.log

[patch] Don't log passwords in ipaserver-install.log

freeipa-678-password.patch (text/plain), 1.26 KB, created by Rob Crittenden on 2008-02-26 15:48:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Crittenden

Created: 2008-02-26 15:48:15 UTC

Size: 1.26 KB

patch

obsolete

># HG changeset patch
># User Rob Crittenden <rcritten@redhat.com>
># Date 1204040925 18000
># Node ID 3f2aad04b13e0b632b29e5363f9124d4e6daef62
># Parent  a4424f223a9b963b124870e5be06e0625216d885
>Don't log passwords in ipaserver-install.log
>
>433509
>
>diff -r a4424f223a9b -r 3f2aad04b13e ipa-server/ipaserver/dsinstance.py
>--- a/ipa-server/ipaserver/dsinstance.py	Tue Feb 26 09:33:39 2008 -0500
>+++ b/ipa-server/ipaserver/dsinstance.py	Tue Feb 26 10:48:45 2008 -0500
>@@ -23,6 +23,7 @@ import glob
> import glob
> import sys
> import os
>+import re
> 
> from ipa import ipautil
> 
>@@ -175,9 +176,10 @@ class DsInstance(service.Service):
>         self.backup_state("running", self.is_running())
>         self.backup_state("serverid", self.serverid)
>         inf_txt = ipautil.template_str(INF_TEMPLATE, self.sub_dict)
>+        logging.debug("writing inf template")
>+        inf_fd = ipautil.write_tmp_file(inf_txt)
>+        inf_txt = re.sub(r"RootDNPwd=.*\n", "", inf_txt)
>         logging.debug(inf_txt)
>-        inf_fd = ipautil.write_tmp_file(inf_txt)
>-        logging.debug("writing inf template")
>         if ipautil.file_exists("/usr/sbin/setup-ds.pl"):
>             args = ["/usr/sbin/setup-ds.pl", "--silent", "--logfile", "-", "-f", inf_fd.name]
>             logging.debug("calling setup-ds.pl")

Actions: View | Diff

Attachments on bug 433509: 295941