Attachment 296525 Details for Bug 226119 – Patch cleaning up most of the rpmlint complaints and other minor issues for merge review

[patch] Patch cleaning up most of the rpmlint complaints and other minor issues for merge review

merge-review.patch (text/plain), 3.03 KB, created by Todd Zullinger on 2008-03-02 21:51:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Todd Zullinger

Created: 2008-03-02 21:51:20 UTC

Size: 3.03 KB

patch

obsolete

>Index: MAKEDEV.spec
>===================================================================
>RCS file: /cvs/extras/rpms/MAKEDEV/devel/MAKEDEV.spec,v
>retrieving revision 1.59
>diff -u -p -r1.59 MAKEDEV.spec
>--- MAKEDEV.spec	25 Feb 2008 18:46:11 -0000	1.59
>+++ MAKEDEV.spec	2 Mar 2008 21:43:49 -0000
>@@ -1,15 +1,18 @@
> Name: MAKEDEV
> Version: 3.23
>-Release: 3
>+Release: 4
> Group: System Environment/Base
> License: GPL
>+# This is a Red Hat maintained package which is specific to
>+# our distribution.  Thus the source is only available from
>+# within this srpm.
> Source: MAKEDEV-%{version}-1.tar.gz
> Patch0: makedev-3.23-compile-fix.patch
>-Summary: A program used for creating device files in /dev.
>-BuildRoot: %{_tmppath}/%{name}-root
>-BuildPrereq: libselinux-devel
>+Summary: A program used for creating device files in /dev
>+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>+BuildRequires: libselinux-devel
> URL: http://www.lanana.org/docs/device-list/
>-Prereq: /usr/sbin/groupadd, /usr/sbin/useradd, grep, mktemp
>+Requires(pre): shadow-utils
> 
> %description
> This package contains the MAKEDEV program, which makes it easier to create
>@@ -36,10 +39,11 @@ rm -f $RPM_BUILD_ROOT/dev/MAKEDEV
> rm -fr $RPM_BUILD_ROOT
> 
> %pre
>-# Add the floopy group and the vcsa user.
>-/usr/sbin/groupadd -g 19 -r -f floppy > /dev/null 2>/dev/null
>-/usr/sbin/useradd -c "virtual console memory owner" -u 69 \
>-	-s /sbin/nologin -r -d /dev vcsa 2> /dev/null
>+# Add the floppy group and the vcsa user.
>+getent group floppy >/dev/null || groupadd -g 19 -r floppy
>+getent passwd vcsa >/dev/null || \
>+useradd -r -d /dev -s /sbin/nologin -u 69 \
>+    -c "virtual console memory owner" vcsa
> exit 0
> 
> %files
>@@ -51,6 +55,18 @@ exit 0
> %config %{_sysconfdir}/makedev.d
> 
> %changelog
>+* Sun Mar 02 2008 Todd Zullinger <tmz@pobox.com> - 3.23-4
>+- minor cleanups for merge review:
>+  - rpmlint warnings fixed:
>+    - buildprereq and prereq use
>+    - quoted macros in %%changelog
>+    - summary-ended-with-dot
>+  - create vcsa user and floppy group according to packaging guidelines
>+    (Packaging/UsersAndGroups)
>+  - note that we are upstream for MAKEDEV above the source tag
>+  - bring BuildRoot tag in line with the packaging guidelines
>+  - remove grep and mktemp from Require
>+
> * Mon Feb 25 2008 Jeremy Katz <katzj@redhat.com> - 3.23-3
> - Add fix to build with gcc 4.3
> 
>@@ -462,7 +478,7 @@ exit 0
> - generate device manifest with MAKEDEV -M to build as non-root.
> 
> * Wed Jul 11 2001 Bill Nottingham <notting@redhat.com>
>-- add proper prereqs to dev package for %post (#48769)
>+- add proper prereqs to dev package for %%post (#48769)
> 
> * Thu Jul 05 2001 Florian La Roche <Florian.LaRoche@redhat.de>
> - disable unneeded parts of post for s390,s390x
>@@ -491,7 +507,7 @@ exit 0
> - add /dev/shm to fstab too
> 
> * Thu Jun 22 2001 Nalin Dahyabhai <nalin@redhat.com>
>-- own %{_sysconfdir}/makedev.d in addition to files it contains
>+- own %%{_sysconfdir}/makedev.d in addition to files it contains
> 
> * Wed Jun 21 2001 Karsten Hopp <karsten@redhat.de>
> - correct device naming and major/minor numbers on S390

Actions: View | Diff

Attachments on bug 226119: 296525