Attachment 296630 Details for Bug 435730 – Proposed Fix

[patch] Proposed Fix

diffs.txt (text/plain), 3.51 KB, created by Nathan Kinder on 2008-03-03 16:31:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nathan Kinder

Created: 2008-03-03 16:31:52 UTC

Size: 3.51 KB

patch

obsolete

>Index: ldap/servers/plugins/replication/repl5_protocol_util.c
>===================================================================
>RCS file: /cvs/dirsec/ldapserver/ldap/servers/plugins/replication/repl5_protocol_util.c,v
>retrieving revision 1.11
>diff -u -5 -t -r1.11 repl5_protocol_util.c
>--- ldap/servers/plugins/replication/repl5_protocol_util.c	3 Oct 2007 00:55:34 -0000	1.11
>+++ ldap/servers/plugins/replication/repl5_protocol_util.c	3 Mar 2008 16:08:37 -0000
>@@ -376,31 +376,10 @@
>                                                                 return_value = ACQUIRE_SUCCESS;
>                                                                 break;
>                                                         default:
>                                                                 return_value = ACQUIRE_FATAL_ERROR;
>                                                         }
>-                                                        /* Now check for fractional compatibility with the replica 
>-                                                         * We need to do the check now because prior to acquiring the
>-                                                         * replica we do not have sufficient access rights to read the replica id 
>-                                                         */
>-                                                        /* Check if this is a fractional agreement, we need to
>-                                                         * verify that the consumer is read-only */
>-                                                        if ((return_value == ACQUIRE_SUCCESS) &&
>-                                                                agmt_is_fractional(prp->agmt)) {
>-                                                                crc = conn_replica_is_readonly(conn);
>-                                                                if (CONN_IS_NOT_READONLY == crc) {
>-                                                                        /* This is a fatal error */
>-                                                                        slapi_log_error(SLAPI_LOG_FATAL, repl_plugin_name,
>-                                                                                                        "%s: Unable to acquire replica: "
>-                                                                                                        "the agreement is fractional but the replica is not read-only. Fractional agreements must specify a read-only replica "
>-                                                                                                        "Replication is aborting.\n",
>-                                                                                                        agmt_get_long_name(prp->agmt));
>-                                                                        prp->last_acquire_response_code = NSDS50_REPL_INTERNAL_ERROR;
>-                                                                        return_value = ACQUIRE_FATAL_ERROR;
>-                                                                        goto error;
>-                                                                }
>-                                                        }
>                                                 }
>                                                 else
>                                                 {
>                                                         /* Couldn't parse the response */
>                                                         slapi_log_error(SLAPI_LOG_FATAL, repl_plugin_name,

Actions: View | Diff

Attachments on bug 435730: 296630 | 296657