Attachment 296662 Details for Bug 430024 – close fds to prevent AVCs, move logs to /root or /var/log

[patch] close fds to prevent AVCs, move logs to /root or /var/log

freeipa-700-selinux.patch (text/plain), 2.47 KB, created by Rob Crittenden on 2008-03-03 19:14:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Crittenden

Created: 2008-03-03 19:14:43 UTC

Size: 2.47 KB

patch

obsolete

># HG changeset patch
># User Rob Crittenden <rcritten@redhat.com>
># Date 1204571606 18000
># Node ID 16c36d36ca66f6672447b55241dbcbac573a303a
># Parent  12ab3e37b7e6d27e515019842e53173127a66a35
>Close all fds when running another program. This fixes the SELinux AVCs.
>Put the log file into the root user's home directory or /var/log.
>
>diff -r 12ab3e37b7e6 -r 16c36d36ca66 ipa-client/ipa-install/ipa-client-install
>--- a/ipa-client/ipa-install/ipa-client-install	Fri Feb 29 10:58:07 2008 -0500
>+++ b/ipa-client/ipa-install/ipa-client-install	Mon Mar 03 14:13:26 2008 -0500
>@@ -50,11 +50,17 @@ def ask_for_confirmation(message):
>     return True
> 
> def logging_setup(options):
>+
>+    try:
>+        dir=os.environ["HOME"]
>+    except:
>+        dir="/var/log"
>+
>     # Always log everything (i.e., DEBUG) to the log
>     # file.
>     logging.basicConfig(level=logging.DEBUG,
>                         format='%(asctime)s %(levelname)s %(message)s',
>-                        filename='ipaclient-install.log',
>+                        filename=dir + '/ipaclient-install.log',
>                         filemode='w')
> 
>     console = logging.StreamHandler()
>@@ -268,6 +274,7 @@ def main():
> 
> try:
>     import sys
>+    import os
> 
>     import krbV
>     import socket
>diff -r 12ab3e37b7e6 -r 16c36d36ca66 ipa-python/ipautil.py
>--- a/ipa-python/ipautil.py	Fri Feb 29 10:58:07 2008 -0500
>+++ b/ipa-python/ipautil.py	Mon Mar 03 14:13:26 2008 -0500
>@@ -71,7 +71,7 @@ def write_tmp_file(txt):
>     return fd
> 
> def run(args, stdin=None):
>-    p = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
>+    p = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True)
>     if stdin:
>         stdout,stderr = p.communicate(stdin)
>     else:
>diff -r 12ab3e37b7e6 -r 16c36d36ca66 ipa-server/ipa-install/ipa-server-install
>--- a/ipa-server/ipa-install/ipa-server-install	Fri Feb 29 10:58:07 2008 -0500
>+++ b/ipa-server/ipa-install/ipa-server-install	Mon Mar 03 14:13:26 2008 -0500
>@@ -316,7 +316,13 @@ def main():
>     signal.signal(signal.SIGTERM, signal_handler)
>     signal.signal(signal.SIGINT, signal_handler)
> 
>-    standard_logging_setup("ipaserver-install.log", options.debug)
>+    try:
>+        dir=os.environ["HOME"]
>+    except:
>+        dir="/var/log"
>+
>+    standard_logging_setup(dir + "/ipaserver-install.log", options.debug)
>+    print "\nThe log file for this installation can be found in %s\n" % (dir + "/ipaserver-install.log")
> 
>     if options.uninstall:
>         return uninstall()

Actions: View | Diff

Attachments on bug 430024: 296643 | 296662