Attachment 297204 Details for Bug 434786 – Remove check for file existence in cli tools.

[patch] Remove check for file existence in cli tools.

virtinst-0.300.2-remove-file-exist-check.patch (text/plain), 1.96 KB, created by Cole Robinson on 2008-03-07 16:23:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Cole Robinson

Created: 2008-03-07 16:23:56 UTC

Size: 1.96 KB

patch

obsolete

># HG changeset patch
># User "Daniel P. Berrange <berrange@redhat.com>"
># Date 1204082966 18000
># Node ID 52f657ebcb4d73d2cc6d3e2777c0acd7b49fc1bf
># Parent  96a8994ff871ab67c1cdb551f915b35de45240d9
>Remove check for local file existance since it doesn't work remotely & is causing needless interactive prompts
>
>diff -r 96a8994ff871 -r 52f657ebcb4d virt-clone
>--- a/virt-clone	Tue Feb 26 20:41:05 2008 -0500
>+++ b/virt-clone	Tue Feb 26 22:29:26 2008 -0500
>@@ -92,12 +92,6 @@ def get_clone_diskfile(new_diskfiles, de
>             if d.is_conflict_disk(conn) is True:
>                 warnmsg = _("Disk %s is already in use by another guest!\n") % d.path
>                 if not cli.prompt_for_yes_or_no(warnmsg + _("Do you really want to use the disk (yes or no)? ")):
>-                    disk = None
>-                    continue
>-            # Overwrite disk?
>-            elif os.path.exists(d.path) and os.path.isfile(d.path):
>-                warnmsg = _("You are going to overwrite file '%s'!\n") % d.path
>-                if not cli.prompt_for_yes_or_no(warnmsg + _("Do you really want to use the file (yes or no)? ")):
>                     disk = None
>                     continue
>             new_diskfiles[i] = d.path
>diff -r 96a8994ff871 -r 52f657ebcb4d virt-install
>--- a/virt-install	Tue Feb 26 20:41:05 2008 -0500
>+++ b/virt-install	Tue Feb 26 22:29:26 2008 -0500
>@@ -84,12 +84,6 @@ def get_disk(disk, size, sparse, guest, 
>                          % d.path
>             if not cli.prompt_for_yes_or_no(warnmsg + _("Do you really want to use the disk (yes or no)? ")):
>                 disk = size = None
>-                continue
>-        # Overwrite disk?
>-        elif os.path.exists(d.path) and os.path.isfile(d.path):
>-            warnmsg = _("You are going to overwrite file '%s'!\n") % d.path
>-            if not cli.prompt_for_yes_or_no(warnmsg + _("Do you really want to use the file (yes or no)? ")):
>-                disk = None
>                 continue
> 
>         guest.disks.append(d)

Actions: View | Diff

Attachments on bug 434786: 296947 | 296949 | 297055 | 297203 | 297204