Attachment 297250 Details for Bug 436132 – patch 1 -- always fake pre_op_attrs

[patch] patch 1 -- always fake pre_op_attrs

0001-BZ-436132-Always-fake-wcc-pre_op_attrs-on-write-rep.patch (text/plain), 1.43 KB, created by Jeff Layton on 2008-03-07 21:01:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2008-03-07 21:01:32 UTC

Size: 1.43 KB

patch

obsolete

>From b04cc95de88e17dbd78aeab8480af32d8512cf39 Mon Sep 17 00:00:00 2001
>From: Jeff Layton <jlayton@redhat.com>
>Date: Fri, 7 Mar 2008 15:58:08 -0500
>Subject: [PATCH] BZ#436132: Always fake wcc pre_op_attrs on write replies
>
>Write replies don't necessarily come in in the same order that they
>are committed to disk. It's easily possible for the wcc pre_op_attrs
>to not match the current mtime on the file, even if there are no
>other writers.
>
>Attempt to reduce the amount of cache invalidations due to
>post-op-attr updates by always faking up wcc pre_op_attrs on
>write replies.
>---
> fs/nfs/inode.c |    6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
>index eea0174..47199a0 100644
>--- a/fs/nfs/inode.c
>+++ b/fs/nfs/inode.c
>@@ -1481,13 +1481,11 @@ out:
>  */
> int nfs_post_op_update_inode_force_wcc(struct inode *inode, struct nfs_fattr *fattr)
> {
>-	if ((fattr->valid & NFS_ATTR_FATTR_V4) != 0 &&
>-			(fattr->valid & NFS_ATTR_WCC_V4) == 0) {
>+	if ((fattr->valid & NFS_ATTR_FATTR_V4) != 0) {
> 		fattr->pre_change_attr = NFS_I(inode)->change_attr;
> 		fattr->valid |= NFS_ATTR_WCC_V4;
> 	}
>-	if ((fattr->valid & NFS_ATTR_FATTR) != 0 &&
>-			(fattr->valid & NFS_ATTR_WCC) == 0) {
>+	if ((fattr->valid & NFS_ATTR_FATTR) != 0) {
> 		memcpy(&fattr->pre_ctime, &inode->i_ctime, sizeof(fattr->pre_ctime));
> 		memcpy(&fattr->pre_mtime, &inode->i_mtime, sizeof(fattr->pre_mtime));
> 		fattr->pre_size = inode->i_size;
>-- 
>1.5.3.6
>

Actions: View | Diff

Attachments on bug 436132: 297190 | 297191 | 297250 | 297251 | 297252 | 309488 | 309489 | 309490 | 309620