Attachment 297474 Details for Bug 296851 – Patch for further debugging of serial issues

[patch] Patch for further debugging of serial issues

serial-debug.patch (text/plain), 1.44 KB, created by Dan Williams on 2008-03-10 17:57:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dan Williams

Created: 2008-03-10 17:57:36 UTC

Size: 1.44 KB

patch

obsolete

>Index: src/nm-serial-device.c
>===================================================================
>--- src/nm-serial-device.c	(revision 3410)
>+++ src/nm-serial-device.c	(working copy)
>@@ -453,6 +453,7 @@ get_reply_got_data (GIOChannel *source,
> 	}
> 
> 	if (condition & G_IO_HUP || condition & G_IO_ERR) {
>+nm_debug ("error condition on read, condition = 0x%X", condition);
> 		g_string_free (info->result, TRUE);
> 		info->result = NULL;
> 		done = TRUE;
>@@ -461,6 +462,7 @@ get_reply_got_data (GIOChannel *source,
> 	if (done) {
> 		char *result = info->result ? g_string_free (info->result, FALSE) : NULL;
> 		info->result = NULL;
>+nm_debug ("calling callback with result '%s'", result ? result : "<none>");
> 		info->callback (info->device, result, info->user_data);
> 		g_free (result);
> 
>@@ -468,6 +470,8 @@ get_reply_got_data (GIOChannel *source,
> 		info->got_data_id = 0;
> 		g_source_remove (info->timeout_id);
> 	}
>+else
>+nm_debug ("not done");
> 
> 	return !done;
> }
>@@ -576,15 +580,21 @@ wait_for_reply_got_data (GIOChannel *sou
> 	}
> 
> 	if (condition & G_IO_HUP || condition & G_IO_ERR)
>+{
>+nm_debug ("error condition on read, condition = 0x%X", condition);
> 		done = TRUE;
>+}
> 
> 	if (done) {
>+nm_debug ("calling callback with idx %d", idx);
> 		info->callback (info->device, idx, info->user_data);
> 
> 		/* Clear the id - returning FALSE already removes it */
> 		info->got_data_id = 0;
> 		g_source_remove (info->timeout_id);
> 	}
>+else
>+nm_debug ("not done");
> 
> 	return !done;
> }

Actions: View | Diff

Attachments on bug 296851: 292151 | 292155 | 296514 | 296809 | 296810 | 297474 | 297506 | 297526 | 297527 | 302763 | 302895