Attachment 298011 Details for Bug 437430 – Patch for fix this problem.

[patch] Patch for fix this problem.

nfs_write_pageuptodate.patch (text/plain), 1.39 KB, created by jiangguiqing on 2008-03-14 03:50:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: jiangguiqing

Created: 2008-03-14 03:50:30 UTC

Size: 1.39 KB

patch

obsolete

>--- linux-2.6.23.i686/fs/nfs/write.c.orig	2008-03-06 20:23:46.000000000 +0800
>+++ linux-2.6.23.i686/fs/nfs/write.c	2008-03-06 20:30:50.000000000 +0800
>@@ -708,6 +708,17 @@ int nfs_flush_incompatible(struct file *
> }
> 
> /*
>+ * If the page cache is marked as unsafe or invalid, then we can't rely on
>+ * the PageUptodate() flag. In this case, we will need to turn off
>+ * write optimisations that depend on the page contents being correct.
>+ */
>+static int nfs_write_pageuptodate(struct page *page, struct inode *inode)
>+{
>+	return PageUptodate(page) &&
>+		!(NFS_I(inode)->cache_validity & (NFS_INO_REVAL_PAGECACHE|NFS_INO_INVALID_DATA));
>+}
>+
>+/*
>  * Update and possibly write a cached page of an NFS file.
>  *
>  * XXX: Keep an eye on generic_file_read to make sure it doesn't do bad
>@@ -730,8 +741,13 @@ int nfs_updatepage(struct file *file, st
> 	/* If we're not using byte range locks, and we know the page
> 	 * is entirely in cache, it may be more efficient to avoid
> 	 * fragmenting write requests.
>+	 * is up to date, it may be more efficient to extend the write
>+	 * to cover the entire page in order to avoid fragmentation
>+	 * inefficiencies.
> 	 */
>-	if (PageUptodate(page) && inode->i_flock == NULL && !(file->f_mode & O_SYNC)) {
>+	if (nfs_write_pageuptodate(page, inode) &&
>+			inode->i_flock == NULL &&
>+			!(file->f_flags & O_SYNC)) {
> 		count = max(count + offset, nfs_page_length(page));
> 		offset = 0;
> 	}

Actions: View | Diff

Attachments on bug 437430: 298011