Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 298044 Details for
Bug 437469
"unix2dos -n" creates files with overly restrictive permissions
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Proposed Patch
unix2dos-2.2-preserve-new-file-modes.patch (text/plain), 915 bytes, created by
john.haxby@oracle.com
on 2008-03-14 13:13:01 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
john.haxby@oracle.com
Created:
2008-03-14 13:13:01 UTC
Size:
915 bytes
patch
obsolete
>diff -up unix2dos-2.2/unix2dos.c~ unix2dos-2.2/unix2dos.c >--- unix2dos-2.2/unix2dos.c~ 2008-03-03 13:16:34.000000000 +0000 >+++ unix2dos-2.2/unix2dos.c 2008-03-03 13:22:10.000000000 +0000 >@@ -244,10 +244,11 @@ int ConvertUnixToDosNewFile(char *ipInFN > char *TempPath; > struct stat StatBuf; > struct utimbuf UTimeBuf; >+ mode_t mask; > int fd; > > /* retrieve ipInFN file date stamp */ >- if ((ipFlag->KeepDate) && stat(ipInFN, &StatBuf)) >+ if (stat(ipInFN, &StatBuf)) > RetVal = -1; > > if((fd = MakeTempFileFrom (ipOutFN, &TempPath)) < 0) { >@@ -271,6 +272,12 @@ int ConvertUnixToDosNewFile(char *ipInFN > RetVal = -1; > } > >+ /* preserve original mode as modified by umask */ >+ mask = umask(0); >+ umask(mask); >+ if (!RetVal && fchmod(fd, StatBuf.st_mode & ~mask)) >+ RetVal = -1; >+ > /* conversion sucessful? */ > if ((!RetVal) && (ConvertUnixToDos(InF, TempF, ipFlag))) > RetVal = -1;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=298044">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 437469
: 298044