Attachment 298078 Details for Bug 437544 – patch -- change nfs3_write_done and nfs3_commit_done to do the right revalidations afterward

[patch] patch -- change nfs3_write_done and nfs3_commit_done to do the right revalidations afterward

0012-BZ-437544-fix-transposed-deltas-in-nfs3_write_done-a.patch (text/plain), 1.48 KB, created by Jeff Layton on 2008-03-14 20:20:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2008-03-14 20:20:34 UTC

Size: 1.48 KB

patch

obsolete

>From fac80ce877ff55ec06aa4a8bb204bf6eec94a561 Mon Sep 17 00:00:00 2001
>From: Jeff Layton <jlayton@redhat.com>
>Date: Thu, 13 Mar 2008 17:10:11 -0400
>Subject: [PATCH] BZ#437544: fix transposed deltas in nfs3_write_done and nfs3_commit_done
>
>There appear to be transposed deltas in nfs3_write_done and
>nfs3_commit_done in the patch for BZ 321111. COMMIT calls shouldn't
>change the mtimes and so we shouldn't need to use the force_wcc
>call after one. Writes on the other hand generally do change the
>mtime, so we want to make sure we force_wcc after one so that we
>don't invalidate the cache due to our own writes.
>---
> fs/nfs/nfs3proc.c |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/fs/nfs/nfs3proc.c b/fs/nfs/nfs3proc.c
>index 86e1529..0246904 100644
>--- a/fs/nfs/nfs3proc.c
>+++ b/fs/nfs/nfs3proc.c
>@@ -822,7 +822,8 @@ static int nfs3_write_done(struct rpc_task *task, struct nfs_write_data *data)
> {
> 	if (nfs3_async_handle_jukebox(task, data->inode))
> 		return -EAGAIN;
>-	nfs_refresh_inode(data->inode, data->res.fattr);
>+	if (task->tk_status >= 0)
>+		nfs_post_op_update_inode_force_wcc(data->inode, data->res.fattr);
> 	return 0;
> }
> 
>@@ -850,8 +851,7 @@ static int nfs3_commit_done(struct rpc_task *task, struct nfs_write_data *data)
> {
> 	if (nfs3_async_handle_jukebox(task, data->inode))
> 		return -EAGAIN;
>-	if (task->tk_status >= 0)
>-		nfs_post_op_update_inode_force_wcc(data->inode, data->res.fattr);
>+	nfs_refresh_inode(data->inode, data->res.fattr);
> 	return 0;
> }
> 
>-- 
>1.5.3.6
>

Actions: View | Diff

Attachments on bug 437544: 298078