Attachment 298290 Details for Bug 437566 – allow realm to be included in add_service_principal() call

[patch] allow realm to be included in add_service_principal() call

freeipa-721-realm.patch (text/plain), 1.72 KB, created by Rob Crittenden on 2008-03-17 18:10:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Crittenden

Created: 2008-03-17 18:10:27 UTC

Size: 1.72 KB

patch

obsolete

># HG changeset patch
># User Rob Crittenden <rcritten@redhat.com>
># Date 1205777384 14400
># Node ID 05f1552e78442d7b612b262a8d9f271c237738ab
># Parent  3681cce7799f1b165dda017ea431e35838fd4d26
>Allow the realm to be included in the name passed to add_service_principal()
>This is more kerberos-like and it doesn't hurt anything, we just won't
>allow realms other than our own to be used.
>
>437566
>
>diff -r 3681cce7799f -r 05f1552e7844 ipa-python/ipaerror.py
>--- a/ipa-python/ipaerror.py	Mon Mar 17 13:16:56 2008 -0400
>+++ b/ipa-python/ipaerror.py	Mon Mar 17 14:09:44 2008 -0400
>@@ -158,6 +158,11 @@ INPUT_MALFORMED_SERVICE_PRINCIPAL = gen_
>         0x0005,
>         "The requested service principal is not of the form: service/fully-qualified host name")
> 
>+INPUT_REALM_MISMATCH = gen_error_code(
>+        INPUT_CATEGORY,
>+        0x0006,
>+        "The realm for the principal does not match the realm for this IPA server.")
>+
> #
> # Connection errors
> #
>diff -r 3681cce7799f -r 05f1552e7844 ipa-server/xmlrpc-server/funcs.py
>--- a/ipa-server/xmlrpc-server/funcs.py	Mon Mar 17 13:16:56 2008 -0400
>+++ b/ipa-server/xmlrpc-server/funcs.py	Mon Mar 17 14:09:44 2008 -0400
>@@ -1820,9 +1820,12 @@ class IPAServer:
> 
>         # Don't let the user set the realm
>         if name.find('@') > 0:
>-            raise ipaerror.gen_exception(ipaerror.INPUT_INVALID_PARAMETER)
>-
>-        princ_name = name + "@" + self.realm
>+            r = name[name.find('@')+1:]
>+            if (r != self.realm):
>+                raise ipaerror.gen_exception(ipaerror.INPUT_REALM_MISMATCH)
>+            princ_name = name
>+        else:
>+            princ_name = name + "@" + self.realm
>         
>         conn = self.getConnection(opts)
>         if not self.__is_service_unique(name, opts):

Actions: View | Diff

Attachments on bug 437566: 298290