Attachment 298752 Details for Bug 438443 – Patch to hide full list of flags/groups unless you need to edit them (v1)

[patch] Patch to hide full list of flags/groups unless you need to edit them (v1)

hide_flags_groups.patch (text/plain), 6.59 KB, created by David Lawrence on 2008-03-20 21:56:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Lawrence

Created: 2008-03-20 21:56:23 UTC

Size: 6.59 KB

patch

obsolete

>Index: template/en/default/bug/edit.html.tmpl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/template/en/default/bug/edit.html.tmpl,v
>retrieving revision 1.15
>diff -u -r1.15 edit.html.tmpl
>--- template/en/default/bug/edit.html.tmpl	17 Mar 2008 21:48:08 -0000	1.15
>+++ template/en/default/bug/edit.html.tmpl	20 Mar 2008 21:07:14 -0000
>@@ -656,25 +656,31 @@
>         <label id="bz_restrict_group_visibility_label"><b> Restrict Group Visibility</b>:</label>
>       </td>
>       <td>
>+        <div id="bz_restrict_group_visibility_help">
>+          <b>Only users in [% IF Param('or_groups') %]any[% ELSE %]all[% END %] of the selected groups can view this [% terms.bug %]:</b>
>+          <br>
>+          <font size="-1">
>+            (Unchecking all boxes makes this a more public [% terms.bug %].)
>+          </font>
>+        </div>
>+        <div id="bz_groups_edit_container" class="bz_default_hidden">
>+          <span>
>+            <b>Current Groups</b>: (<a href="#" id="bz_groups_edit_action">edit</a>)<br>
>+            [% inagroup = 0 %]
>+            [% FOREACH group = bug.groups %]
>+              [% IF group.ison %][% group.description FILTER html_light %]<br>[% END %]
>+              [% SET inagroup = 1 IF group.ison %]
>+            [% END %]
>+            [% IF NOT inagroup %]None Set[% END %]
>+          </span>
>+        </div>
>+        <div id="bz_groups_input"> 
>         [% inallgroups = 1 %]
>-        [% inagroup = 0 %]
>         [% FOREACH group = bug.groups %]
>           [% SET inallgroups = 0 IF NOT group.ingroup %]
>-          [% SET inagroup = 1 IF group.ison %]
> 
>           [% NEXT IF group.mandatory %]
> 
>-          [% IF NOT emitted_description %]
>-            [% emitted_description = 1 %]
>-            <div id="bz_restrict_group_visibility_help">
>-              <b>Only users in [% IF Param('or_groups') %]any[% ELSE %]all[% END %] of the selected groups can view this [% terms.bug %]:</b>
>-              <br>
>-              <font size="-1">
>-                (Unchecking all boxes makes this a more public [% terms.bug %].)
>-              </font>
>-            </div>
>-          [% END %]
>-
>           [% IF group.ingroup %]
>             <input type="hidden" name="defined_bit-[% group.bit %]" value="1">
>           [% END %]
>@@ -693,6 +699,12 @@
>           </b>
>           <br>
>         [% END %]
>+        </div>
>+        <script type="text/javascript">
>+          hideEditableField('bz_groups_edit_container', 
>+                            'bz_groups_input', 
>+                            'bz_groups_edit_action');
>+        </script>
>       </td>
>     </tr>
> 
>@@ -714,7 +726,14 @@
>             the [% terms.bug %] is restricted to at least one group.)
>           </small>
>         </div>
>-        <div>
>+        <div id="bz_group_roles_edit_container" class="bz_default_hidden">
>+          <span>
>+            <b>Current Roles</b>: (<a href="#" id="bz_group_roles_edit_action">edit</a>)<br>
>+            [% IF NOT bug.reporter_accessible AND NOT bug.cclist_accessible %]None Set[% END %]
>+            [% IF bug.reporter_accessible %]Reporter[% END %][% IF bug.cclist_accessible %][% IF bug.reporter_accessible %], [% END %]CC List[% END %]
>+          </span>
>+        </div>
>+        <div id="bz_group_roles_input">
>           <div>
>             [% user_can_edit_accessible = bug.check_can_change_field("reporter_accessible", 0, 1) %]
>             [% IF user_can_edit_accessible %]
>@@ -738,6 +757,11 @@
>             <label for="cclist_accessible">CC List</label>
>           </div>
>         </div>
>+        <script type="text/javascript">
>+          hideEditableField('bz_group_roles_edit_container', 
>+                            'bz_group_roles_input', 
>+                            'bz_group_roles_edit_action');
>+        </script>
>       </td>
>     </tr>
>     [% END %]
>@@ -868,37 +892,54 @@
>       <td class="field_label">
>         <label><b>Flags:</b></label>
>       </td>
>-      <td></td>
>-    </tr>
>-    <tr>
>-      <td colspan="2">
>-    [% show_bug_flags = 0 %]
>-    [% FOREACH type = bug.flag_types %]
>-      [% IF (type.flags && type.flags.size > 0) || (user.id && type.is_active) %]
>-        [% show_bug_flags = 1 %]
>-        [% LAST %]
>-      [% END %]
>-    [% END %]
>-    [% IF show_bug_flags %]
>-    
>+      <td>
>       [% IF user.id %]
>-        [% IF bug.flag_types.size > 0 %]
>-          [% PROCESS "flag/list.html.tmpl" flag_no_header = 1
>-                                           flag_types = bug.flag_types
>-                                           any_flags_requesteeble = bug.any_flags_requesteeble %]
>-        [% END %]
>+        <div id="bz_flags_edit_container" class="bz_default_hidden">
>+          <span>
>+            (<a href="#" id="bz_flags_edit_action">edit</a>)<br>
>+            [% setflags = 0 %]
>+            [% FOREACH type = bug.flag_types %]
>+              [% FOREACH flag = type.flags %]
>+                [% setflags = 1 %]
>+                [% flag.setter.nick FILTER html %]:
>+                [%+ type.name FILTER html FILTER no_break %][% flag.status %]
>+                [%+ IF flag.requestee %]
>+                  ([% flag.requestee.nick FILTER html %])
>+                [% END %]<br>
>+              [% END %]
>+            [% END %]
>+            [% IF NOT setflags %]None Set[% END %]
>+          </span>
>+        </div>
>       [% ELSE %]
>         [% FOREACH type = bug.flag_types %]
>           [% FOREACH flag = type.flags %]
>-              [% flag.setter.nick FILTER html %]:
>-              [%+ type.name FILTER html FILTER no_break %][% flag.status %]
>-              [%+ IF flag.requestee %]
>-                ([% flag.requestee.nick FILTER html %])
>-              [% END %]<br>
>+            [% flag.setter.nick FILTER html %]:
>+            [%+ type.name FILTER html FILTER no_break %][% flag.status %]
>+            [%+ IF flag.requestee %]
>+              ([% flag.requestee.nick FILTER html %])
>+            [% END %]<br>
>           [% END %]
>         [% END %]
>-      [% END %]         
>-    [% END %]
>+      [% END %]
>+      </td>
>+    </tr>
>+    <tr>
>+      <td colspan="2">
>+      [% IF user.id %]
>+        <div id="bz_flags_input">
>+          [% IF bug.flag_types.size > 0 %]
>+            [% PROCESS "flag/list.html.tmpl" flag_no_header = 1
>+                                             flag_types = bug.flag_types
>+                                             any_flags_requesteeble = bug.any_flags_requesteeble %]
>+          [% END %]
>+        </div>
>+      [% END %]
>+      <script type="text/javascript">
>+        hideEditableField('bz_flags_edit_container', 
>+                          'bz_flags_input', 
>+                          'bz_flags_edit_action');
>+      </script>
>       </td>
>     </tr>
>   [% END %]

Flags:

nelhawar: review+

Actions: View | Diff

Attachments on bug 438443: 298752