Attachment 298755 Details for Bug 247448 – Make vgreduce use vg_split_mdas

[patch] Make vgreduce use vg_split_mdas

vgreduce-split-mdas.patch (text/plain), 1.42 KB, created by Bryn M. Reeves on 2008-03-20 22:34:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bryn M. Reeves

Created: 2008-03-20 22:34:43 UTC

Size: 1.42 KB

patch

obsolete

>Index: LVM2/tools/vgreduce.c
>===================================================================
>--- LVM2.orig/tools/vgreduce.c
>+++ LVM2/tools/vgreduce.c
>@@ -353,6 +353,8 @@ static int _vgreduce_single(struct cmd_c
> 			    void *handle __attribute((unused)))
> {
> 	struct pv_list *pvl;
>+	struct volume_group *orphan_vg;
>+	int consistent = 1;
> 	const char *name = pv_dev_name(pv);
> 
> 	if (pv_pe_alloc_count(pv)) {
>@@ -388,6 +390,24 @@ static int _vgreduce_single(struct cmd_c
> 	vg->free_count -= pv_pe_count(pv) - pv_pe_alloc_count(pv);
> 	vg->extent_count -= pv_pe_count(pv);
> 
>+	if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
>+		log_error("Can't get lock for orphan PVs");
>+		return ECMD_FAILED;
>+	}
>+
>+	if(!(orphan_vg = vg_read(cmd, vg->fid->fmt->orphan_vg_name, NULL, &consistent))) {
>+		log_error("Unable to read orphan PVs");
>+		unlock_vg(cmd, VG_ORPHANS);
>+		return ECMD_FAILED;
>+	}
>+
>+	if (!(vg_split_mdas(cmd, vg, orphan_vg) && vg->pv_count)) {
>+		log_error("Cannot remove final metadata area on \"%s\" from \"%s\"",
>+			  name, vg->name);
>+		unlock_vg(cmd, VG_ORPHANS);
>+		return ECMD_FAILED;
>+	}
>+
> 	if (!vg_write(vg) || !vg_commit(vg)) {
> 		log_error("Removal of physical volume \"%s\" from "
> 			  "\"%s\" failed", name, vg->name);
>@@ -401,6 +421,8 @@ static int _vgreduce_single(struct cmd_c
> 		return ECMD_FAILED;
> 	}
> 
>+	unlock_vg(cmd, VG_ORPHANS);
>+
> 	backup(vg);
> 
> 	log_print("Removed \"%s\" from volume group \"%s\"", name, vg->name);

Actions: View | Diff

Attachments on bug 247448: 158763 | 298754 | 298755