Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 299040 Details for
Bug 438741
kernel panic due to HP Watchdog firing (hpwdt)
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
RHEL5 fix for this issue
438741.patch (text/plain), 1.22 KB, created by
Prarit Bhargava
on 2008-03-25 15:37:56 UTC
(
hide
)
Description:
RHEL5 fix for this issue
Filename:
MIME Type:
Creator:
Prarit Bhargava
Created:
2008-03-25 15:37:56 UTC
Size:
1.22 KB
patch
obsolete
>Since the system NMI handler runs every 30 seconds, the HP watchdog handler >will examine an interrupt at least every 30 seconds. > >The existing code spits out a message every 30 seconds saying that "An NMI >occurred, but unable to determine source." Users really don't care. > >Additionally, returning NOTIFY_STOP from this function results in the NMI >being disabled. Return NOTIFY_DONE, which is a more appropriate thing to do. > >Resolves BZ 438741. > >diff --git a/drivers/char/watchdog/hpwdt.c b/drivers/char/watchdog/hpwdt.c >index 078c954..5b98188 100644 >--- a/drivers/char/watchdog/hpwdt.c >+++ b/drivers/char/watchdog/hpwdt.c >@@ -615,15 +615,14 @@ static int hpwdt_pretimeout(struct notifier_block *nb, unsigned long ulReason, > asminline_call(&cmn_regs, gpVirtRomCRUAddr); > die_nmi_called = 1; > spin_unlock_irqrestore(&rom_lock, rom_pl); >- if (cmn_regs.u1.ral == 0) { >- printk(KERN_WARNING "hpwdt: An NMI occurred, " >- "but unable to determine source.\n"); >- } else { >+ if (cmn_regs.u1.ral != 0) { > panic("An NMI occurred, please see the Integrated " >- "Management Log for details.\n"); >+ "Management Log for details.\n"); > } > } >- return NOTIFY_STOP; >+ >+ die_nmi_called = 0; >+ return NOTIFY_DONE; > } > > /*
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 438741
:
298930
| 299040 |
299947