Attachment 299214 Details for Bug 438956 – Patch to translate urls

[patch] Patch to translate urls

0001-Use-urllib.unquote-quote-to-create-proper-urls-when.patch (text/plain), 1.45 KB, created by Jesse Keating on 2008-03-26 19:06:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jesse Keating

Created: 2008-03-26 19:06:29 UTC

Size: 1.45 KB

patch

obsolete

>From da95fd8fd50c91852c8419d3988484ee3c62478a Mon Sep 17 00:00:00 2001
>From: Jesse Keating <jkeating@redhat.com>
>Date: Wed, 26 Mar 2008 15:02:14 -0400
>Subject: [PATCH] Use urllib.unquote/quote to create proper urls when special chars are passed.
>
>We have to unquote first in case pre-translated urls are passed in or mixed
>urls.  After unquoting we can requote to have a fully clean url to hand back
>to the client.
>---
> mirrors/server-scripts/mirrorlist_server.py |    7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
>diff --git a/mirrors/server-scripts/mirrorlist_server.py b/mirrors/server-scripts/mirrorlist_server.py
>index 1a10f45..21b7e72 100755
>--- a/mirrors/server-scripts/mirrorlist_server.py
>+++ b/mirrors/server-scripts/mirrorlist_server.py
>@@ -13,6 +13,8 @@ from IPy import IP
> import GeoIP
> import bisect
> 
>+import urllib
>+
> # can be overridden on the command line
> socketfile = '/tmp/mirrormanager_mirrorlist_server.sock'
> cachefile = '/tmp/mirrorlist_cache.pkl'
>@@ -239,7 +241,10 @@ def do_mirrorlist(kwargs):
>     file = None
>     cache = None
>     if kwargs.has_key('path'):
>-        path = kwargs['path'].strip('/')
>+        # quote/unquote here to handle when a client may send say %2B direcly
>+        # instead of +, or a mix of both.  Re-quote to have everything in a
>+        # clean url.
>+        path = urllib.quote(urllib.unquote(kwargs['path'].strip('/')))
>         header = "# path = %s " % (path)
> 
>         sdir = path.split('/')
>-- 
>1.5.4.4
>

Actions: View | Diff

Attachments on bug 438956: 299214