Attachment 299750 Details for Bug 439850 – Proposed patch copied from upstream.

[patch] Proposed patch copied from upstream.

virtinst-0.300.2-handle-libvirt-errors.patch (text/plain), 1.55 KB, created by Bryan Mason on 2008-03-31 18:51:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bryan Mason

Created: 2008-03-31 18:51:00 UTC

Size: 1.55 KB

patch

obsolete

># HG changeset patch
># User "Cole Robinson <crobinso@redhat.com>"
># Date Fri Feb 22 13:40:59 2008 -0500
># Node ID dc3dd659f7df09ca9496fa63b1a73d07eeba4573
># parent: 549bd0ef2ef7931789c4ff4f601d2efa1152c5ae
>Use libvirt error handlers and custom exception handler.
>
>The libvirt error handler will ignore all error messages, as these errors
>should be raised as exceptions anyways and dealt with that way. This prevents
>a deliberately ignored exception from still dumping a libvirt error
>to the console (such as during domain create when we would us lookupByName
>to ensure there wasn't a domain name conflict).
>
>--- a/virtinst/cli.py	Tue Feb 19 16:37:13 2008 -0500
>+++ b/virtinst/cli.py	Fri Feb 22 13:40:59 2008 -0500
>@@ -65,6 +65,22 @@ def setupLogging(appname, debug=False):
>     else:
>         streamHandler.setLevel(logging.ERROR)
>     rootLogger.addHandler(streamHandler)
>+
>+    # Register libvirt handler
>+    def libvirt_callback(ctx, err):
>+        if err[3] != libvirt.VIR_ERR_ERROR:
>+            # Don't log libvirt errors: global error handler will do that
>+            logging.warn("Non-error from libvirt: '%s'" % err[2])
>+    libvirt.registerErrorHandler(f=libvirt_callback, ctx=None)
>+
>+    # Register python error handler to log exceptions
>+    def exception_log(type, val, tb):
>+        import traceback
>+        str = traceback.format_exception(type, val, tb)
>+        logging.exception("".join(str))
>+        sys.__excepthook__(type, val, tb)
>+    sys.excepthook = exception_log
>+
> 
> def getConnection(connect):
>     if connect is None or connect.lower()[0:3] == "xen":
>

Actions: View | Diff

Attachments on bug 439850: 299750