Attachment 299799 Details for Bug 439937 – patch to 'fix' the copies/collate/reverse behaviour

[patch] patch to 'fix' the copies/collate/reverse behaviour

evince-0.6.0-copies.patch (text/plain), 1.74 KB, created by Jonathan Peatfield on 2008-04-01 01:18:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Peatfield

Created: 2008-04-01 01:18:12 UTC

Size: 1.74 KB

patch

obsolete

>--- shell/ev-jobs.c.ncopies	2008-03-28 19:43:09.000000000 +0000
>+++ shell/ev-jobs.c	2008-04-01 00:43:22.000000000 +0100
>@@ -675,16 +675,26 @@
> 			      MAX (first_page, last_page),
> 			      job->width, job->height, FALSE);
> 
>-	for (i = 0; i < job->copies; i++) {
>+	/* Don't try to do the print spooler's job for it, leave
>+	   n-copies, collate, reverse etc up to cups (or any other
>+	   gtk_print backend perhaps?) 2008-03-31 JSP */
>+
>+#ifdef JSPDEBUGEVP
>+	/* JSP debug */
>+	g_warning (__FILE__" JSP debug of ev_pjr (near top) with copies=%d, collate=%d",
>+		   job->copies, job->collate);
>+#endif
>+	{
> 		gint page, step;
> 		
>-		step = job->reverse ? -1 : 1;
>-		page = job->reverse ? last_page : first_page;
>-		while ((job->reverse && (page >= first_page)) ||
>-		       (!job->reverse && (page <= last_page))) {
>-			gint n_pages = 1;
>-			gint j;
>-
>+/* cups will handle reversing the document if requested, similarly it
>+   handles n-copies and reverse printing if they get passed though.
>+   As this code used to be requesting N copies from a pdf (say)
>+   resulted in N*N copies being printed!!  2008-03-31 JSP */
>+
>+		step = 1;
>+		page = first_page;
>+		while (page <= last_page) {
> 			if (job->n_ranges > 0 &&
> 			    !ev_print_job_print_page_in_range (job, page)) {
> 				page += step;
>@@ -696,18 +706,15 @@
> 				continue;
> 			}
> 
>-			if (job->collate)
>-				n_pages = job->copies;
>-
>-			for (j = 0; j < n_pages; j++) {
>+#ifdef JSPDEBUGEVP
>+			/* JSP debug */
>+			g_warning (__FILE__" JSP debug of ev_pjr inside loop with copies=%d collate=%d page=%d step=%d",
>+				   job->copies, job->collate, page, step);
>+#endif
> 				ev_job_print_do_page (job, page);
>-			}
> 
> 			page += step;
> 		}
>-
>-		if (job->collate)
>-			break;
> 	}
> 
> 	ev_ps_exporter_end (EV_PS_EXPORTER (document));

Actions: View | Diff

Attachments on bug 439937: 299799