Attachment 300082 Details for Bug 440274 – fix network-attach usage output

[patch] fix network-attach usage output

xen-network-attach.patch (text/plain), 1.61 KB, created by Adam Stokes on 2008-04-02 15:52:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Adam Stokes

Created: 2008-04-02 15:52:20 UTC

Size: 1.61 KB

patch

obsolete

>--- xen-3.1.0-src/tools/python/xen/xm/main.py.orig2	2008-03-31 17:42:42.000000000 +0900
>+++ xen-3.1.0-src/tools/python/xen/xm/main.py	2008-03-31 17:45:50.000000000 +0900
>@@ -127,8 +127,9 @@ SUBCOMMAND_HELP = {
>                         'Destroy a domain\'s virtual block device.'),
>     'block-list'    :  ('<Domain> [--long]',
>                         'List virtual block devices for a domain.'),
>-    'network-attach':  ('<Domain> [--script=<script>] [--ip=<ip>] '
>-                        '[--mac=<mac>]',
>+    'network-attach':  ('<Domain> [type=<type>] [mac=<mac>] [bridge=<bridge>] '
>+                         '[ip=<ip>] [script=<script>] [backend=<BackDomain>] '
>+                         '[vifname=<name>] [rate=<rate>] [model=<model>]', 
>                         'Create a new virtual network device.'),
>     'network-detach':  ('<Domain> <DevId> [-f|--force]',
>                         'Destroy a domain\'s virtual network device.'),
>@@ -1269,13 +1270,20 @@ def xm_block_configure(args):
> 
> 
> def xm_network_attach(args):
>-    arg_check(args, 'network-attach', 1, 10000)
>+    arg_check(args, 'network-attach', 1, 10)
> 
>     dom = args[0]
>     vif = ['vif']
>+    vif_params = ['type', 'mac', 'bridge', 'ip', 'script', \
>+                  'backend', 'vifname', 'rate', 'model']
> 
>     for a in args[1:]:
>-        vif.append(a.split("="))
>+        vif_param = a.split("=")
>+        if len(vif_param) != 2 or vif_param[1] == '' or \
>+           vif_param[0] not in vif_params:
>+            err("Invalid argument: %s" % a)
>+            usage('network-attach')
>+        vif.append(vif_param)
> 
>     server.xend.domain.device_create(dom, vif)
>

Actions: View | Diff

Attachments on bug 440274: 300082