Attachment 300297 Details for Bug 440474 – CVS Diffs

[patch] CVS Diffs

diffs.txt (text/plain), 3.07 KB, created by Nathan Kinder on 2008-04-03 18:13:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nathan Kinder

Created: 2008-04-03 18:13:22 UTC

Size: 3.07 KB

patch

obsolete

>Index: plugins/memberof/memberof.c
>===================================================================
>RCS file: /cvs/dirsec/ldapserver/ldap/servers/plugins/memberof/memberof.c,v
>retrieving revision 1.5
>diff -u -5 -t -r1.5 memberof.c
>--- plugins/memberof/memberof.c	3 Apr 2008 16:52:46 -0000	1.5
>+++ plugins/memberof/memberof.c	3 Apr 2008 17:58:05 -0000
>@@ -583,11 +583,11 @@
>                 (dn = memberof_getdn(pb)))
>         {
>                 /* get the mod set */
>                 slapi_pblock_get(pb, SLAPI_MODIFY_MODS, &mods);
>                 smods = slapi_mods_new();
>-                slapi_mods_init_passin(smods, mods);
>+                slapi_mods_init_byref(smods, mods);
> 
>                 next_mod = slapi_mod_new();
>                 smod = slapi_mods_get_first_smod(smods, next_mod);
>                 while(smod)
>                 {
>@@ -651,10 +651,11 @@
>                         slapi_mod_done(next_mod);
>                         smod = slapi_mods_get_next_smod(smods, next_mod);
>                 }
> 
>                 slapi_mod_free(&next_mod);
>+                slapi_mods_free(&smods);
>         }
> 
>         slapi_log_error( SLAPI_LOG_TRACE, MEMBEROF_PLUGIN_SUBSYSTEM,
>                      "<-- memberof_postop_modify\n" );
>         return ret;
>@@ -921,11 +922,11 @@
>                 if (0 == memberof_compare(&this_dn_val, &to_dn_val))
>                 {
>                         slapi_log_error( SLAPI_LOG_PLUGIN,
>                                 MEMBEROF_PLUGIN_SUBSYSTEM,
>                                 "memberof_modop_one_r: not processing memberOf "
>-                                "operations  on self entry: %s\n", this_dn_val);
>+                                "operations on self entry: %s\n", this_dn_val);
>                         slapi_value_free(&to_dn_val);
>                         slapi_value_free(&this_dn_val);     
>                         goto bail;
>                 }
> 
>@@ -1007,10 +1008,11 @@
>                         }
>                 }
>         }
> 
> bail:
>+        slapi_entry_free(e);
>         return rc;
> }
> 
> 
> /*
>@@ -1305,10 +1307,11 @@
>                 if(attr)
>                 {
>                         rc = 0 == slapi_attr_value_find(
>                                 attr, slapi_value_get_berval(memberdn));
>                 }
>+                slapi_entry_free(group_e);
>         }
> 
>         slapi_sdn_free(&sdn);
>         return rc;
> }
>@@ -1610,10 +1613,12 @@
>                                         pre_index++;
>                                         post_index++;
>                                 }
>                         }
>                 }
>+                slapi_ch_free((void **)&pre_array);
>+                slapi_ch_free((void **)&post_array);
>         }
>         
>         return 0;
> }
> 
>@@ -1823,10 +1828,12 @@
> 
>                 hint = slapi_attr_next_value(memberof, hint, &memberdn);
>         }
> 
> bail:
>+        slapi_entry_free(group_e);
>+        slapi_entry_free(opto_e);
>         slapi_ch_free_string(&filter_str);
> 
>         slapi_log_error( SLAPI_LOG_TRACE, MEMBEROF_PLUGIN_SUBSYSTEM,
>                 "<-- memberof_is_legit_member\n" );
>         return rc;

Actions: View | Diff

Attachments on bug 440474: 300292 | 300297 | 337859