Attachment 301349 Details for Bug 435048 – Avoid using bogus/null values

[patch] Avoid using bogus/null values

pfmon-ia64-checks1.diff (text/plain), 1.32 KB, created by William Cohen on 2008-04-04 21:27:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: William Cohen

Created: 2008-04-04 21:27:03 UTC

Size: 1.32 KB

patch

obsolete

>Index: pfmon/smpl_mod/dear_hist_ia64.c
>===================================================================
>RCS file: /cvsroot/perfmon2/pfmon/pfmon/smpl_mod/dear_hist_ia64.c,v
>retrieving revision 1.12
>retrieving revision 1.13
>diff -U2 -u -r1.12 -r1.13
>--- pfmon/smpl_mod/dear_hist_ia64.c	23 Jan 2008 00:37:05 -0000	1.12
>+++ pfmon/smpl_mod/dear_hist_ia64.c	27 Feb 2008 23:28:08 -0000	1.13
>@@ -187,5 +187,5 @@
> 	unsigned int l2_latency, l3_latency;
> 	size_t	sample_size;
>-	void *hash_desc = csmpl->data, *data;
>+	void *hash_desc, *data;
> 	void *pos;
> 	hash_data_t *hash_entry;
>@@ -198,4 +198,8 @@
> 	hdr   = csmpl->smpl_hdr;
> 
>+	if (hdr == NULL)
>+		return -1;
>+
>+        hash_desc   = csmpl->data;
> 	pos	    = hdr+1;
> 	entry       = options.opt_aggr ? *csmpl->aggr_count : csmpl->entry_count;
>Index: pfmon/smpl_mod/dear_hist_ia64_old_smpl.c
>===================================================================
>RCS file: /cvsroot/perfmon2/pfmon/pfmon/smpl_mod/dear_hist_ia64_old_smpl.c,v
>retrieving revision 1.10
>retrieving revision 1.11
>diff -U2 -u -r1.10 -r1.11
>--- pfmon/smpl_mod/dear_hist_ia64_old_smpl.c	23 Jan 2008 00:37:05 -0000	1.10
>+++ pfmon/smpl_mod/dear_hist_ia64_old_smpl.c	27 Feb 2008 23:28:08 -0000	1.11
>@@ -199,4 +199,8 @@
> 	csmpl = &sdesc->csmpl;
> 	hdr   = csmpl->smpl_hdr;
>+
>+	if (hdr == NULL)
>+		return -1;
>+
> 	hash_desc = csmpl->data;
>

Actions: View | Diff

Attachments on bug 435048: 296007 | 301349