Attachment 303146 Details for Bug 441379 – Patch to fix semanage boolean -D seg fault

[patch] Patch to fix semanage boolean -D seg fault

libsemanage-genhomedirconfix.diff (text/plain), 1.24 KB, created by Stephen Smalley on 2008-04-21 13:44:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stephen Smalley

Created: 2008-04-21 13:44:48 UTC

Size: 1.24 KB

patch

obsolete

>This patch ensures that we do not call genhomedircon if the policy was
>not rebuilt, as there is no need to regenerate home directory contexts
>in that situation.  This avoids the bug for semanage boolean -D while
>still properly handling semodule -Bn aka genhomedircon or other
>operations.
>
>Signed-off-by:  Stephen Smalley <sds@tycho.nsa.gov>
>
>---
>
> libsemanage/src/direct_api.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>Index: trunk/libsemanage/src/direct_api.c
>===================================================================
>--- trunk/libsemanage/src/direct_api.c	(revision 2860)
>+++ trunk/libsemanage/src/direct_api.c	(working copy)
>@@ -708,7 +708,7 @@
> 	/* run genhomedircon if its enabled, this should be the last operation
> 	 * which requires the out policydb */
> 	if (!sh->conf->disable_genhomedircon) {
>-		if ((retval =
>+		if (out && (retval =
> 		     semanage_genhomedircon(sh, out, 1)) != 0) {
> 			ERR(sh, "semanage_genhomedircon returned error code %d.",
> 			    retval);
>
>
>-- 
>Stephen Smalley
>National Security Agency
>
>
>--
>This message was distributed to subscribers of the selinux mailing list.
>If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
>the words "unsubscribe selinux" without quotes as the message.

Actions: View | Diff

Attachments on bug 441379: 301557 | 303146