Attachment 303150 Details for Bug 436099 – force hardreset when SATA link is in sleep mode

force hardreset when SATA link is in sleep mode

linux-2.6-libata-force-hardreset-in-sleep-mode.patch (text/plain), 1.72 KB, created by Chuck Ebbert on 2008-04-21 14:01:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chuck Ebbert

Created: 2008-04-21 14:01:47 UTC

Size: 1.72 KB

patch

obsolete

>Currently, libata doesn't support link powersave modes and always
>disables link PS modes.  However, if the link is already in powersave
>mode when libata begis probing, inhibiting powersave modes by setting
>IPM isn't enough.  Link should be manually transited into active mode
>using SPM or hardreset.
>
>As SPM isn't avalable on all controllers and we're gonna prefer
>hardreset in future anyway, force hardreset if link is in powersave
>mode.
>
>Reported-by: Paul Collins <paul@burly.ondioline.org>
>Signed-off-by: Tejun Heo <htejun@gmail.com>
>---
>Jeff, this isn't necessary for #upstream.
>
>drivers/ata/libata-core.c |   15 +++++++++++++++
>1 file changed, 15 insertions(+)
>
>index be95fdb..e3ddefd 100644
>--- a/drivers/ata/libata-core.c
>+++ b/drivers/ata/libata-core.c
>@@ -3966,11 +3966,26 @@ int ata_std_prereset(struct ata_link *link, unsigned long deadline)
>
>    /* if SATA, resume link */
>    if (ap->flags & ATA_FLAG_SATA) {
>+        u32 sstatus;
>+
>        rc = sata_link_resume(link, timing, deadline);
>        /* whine about phy resume failure but proceed */
>        if (rc && rc != -EOPNOTSUPP)
>            ata_link_printk(link, KERN_WARNING, "failed to resume "
>                    "link for reset (errno=%d)\n", rc);
>+
>+        /* force hardreset if the link is sleeping */
>+        if (sata_scr_read(link, SCR_STATUS, &sstatus) == 0) {
>+            u8 ipm = sstatus >> 8;
>+
>+            if (ipm == 2 || ipm == 6) {
>+                ata_link_printk(link, KERN_INFO,
>+                    "link in %s mode, forcing hardreset\n",
>+                    ipm == 2 ? "partial" : "slumber");
>+                ehc->i.action |= ATA_EH_HARDRESET;
>+                return 0;
>+            }
>+        }
>    }
>
>    /* Wait for !BSY if the controller can wait for the first D2H
>

Actions: View

Attachments on bug 436099: 296974 | 298218 | 298228 | 303150 | 303480 | 303922