Attachment 303198 Details for Bug 227418 – Use a real compilation mode

[patch] Use a real compilation mode

rpm-spec-mode.patch (text/plain), 3.29 KB, created by Chip Coldwell on 2008-04-21 20:12:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chip Coldwell

Created: 2008-04-21 20:12:27 UTC

Size: 3.29 KB

patch

obsolete

>Index: rpm-spec-mode.el
>===================================================================
>RCS file: /cvs/pkgs/rpms/emacs/devel/rpm-spec-mode.el,v
>retrieving revision 1.9
>diff -u -r1.9 rpm-spec-mode.el
>--- rpm-spec-mode.el	6 Nov 2007 16:28:20 -0000	1.9
>+++ rpm-spec-mode.el	21 Apr 2008 20:10:02 -0000
>@@ -63,6 +63,8 @@
> 
> ;;; Code:
> 
>+(require 'compile)
>+
> (defconst rpm-spec-mode-version "0.12x" "Version of `rpm-spec-mode'.")
> 
> (defgroup rpm-spec nil
>@@ -189,11 +191,6 @@
>   :type 'boolean
>   :group 'rpm-spec)
> 
>-(defcustom rpm-spec-use-compilation-mode t
>-  "*If non-nil, build in `compilation-mode' if it's available."
>-  :type 'boolean
>-  :group 'rpm-spec)
>-
> (defcustom rpm-spec-default-release "1"
>   "*Default value for the Release tag in new spec files."
>   :type 'string
>@@ -225,6 +222,11 @@
>   :type 'string
>   :group 'rpm-spec)
> 
>+(defcustom rpm-spec-smp-mflags nil
>+  "*make flags for building on multi-CPU systems, e.g. -j2"
>+  :type 'string
>+  :group 'rpm-spec)
>+
> (defgroup rpm-spec-faces nil
>   "Font lock faces for `rpm-spec-mode'."
>   :prefix "rpm-spec-"
>@@ -1025,20 +1027,35 @@
>       (setq buildoptions (cons "--nodeps" buildoptions)))
>   (if (and rpm-spec-sign-gpg (not rpm-no-gpg))
>       (setq buildoptions (cons "--sign" buildoptions)))
>-  (save-excursion
>-    (set-buffer (get-buffer rpm-buffer-name))
>-    (and rpm-spec-use-compilation-mode
>-         (fboundp 'compilation-mode)
>-         (compilation-mode))
>-    (goto-char (point-max)))
>-  (let* ((process-environment (cons "EMACS=t" process-environment))
>-         (process
>-          (apply 'start-process rpm-spec-build-command rpm-buffer-name
>-                 rpm-spec-build-command buildoptions)))
>-    (if (and rpm-spec-sign-gpg (not rpm-no-gpg))
>-        (let ((rpm-passwd-cache (read-passwd "GPG passphrase: ")))
>-          (process-send-string process (concat rpm-passwd-cache "\n"))))
>-    (set-process-filter process 'rpm-command-filter)))
>+  
>+  (if rpm-spec-smp-mflags
>+      (setq buildoptions
>+	    (cons
>+	     (concat "--define \"_smp_mflags " rpm-spec-smp-mflags "\"")
>+	     buildoptions)))
>+
>+  (if (string-match ".*/SPECS/$" default-directory)
>+      (let ((topdir (expand-file-name default-directory)))
>+	(setq buildoptions
>+	      (cons
>+	       (concat "--define \"_topdir " 
>+		       (replace-regexp-in-string "/SPECS/$" "" topdir)
>+		       "\"")
>+	       buildoptions))))
>+
>+  (progn
>+    (defun list->string (lst)
>+      (if (cdr lst)
>+	  (concat (car lst) " " (list->string (cdr lst)))
>+	(car lst)))
>+    (compilation-start (list->string (cons rpm-spec-build-command buildoptions)) 'rpmbuild-mode))
>+  
>+  (if (and rpm-spec-sign-gpg (not rpm-no-gpg))
>+      (let ((build-proc (get-buffer-process
>+			 (get-buffer
>+			  (compilation-buffer-name "rpmbuild" nil nil))))
>+	    (rpm-passwd-cache (read-passwd "GPG passphrase: ")))
>+	(process-send-string build-proc (concat rpm-passwd-cache "\n")))))
> 
> (defun rpm-build-prepare (&optional arg)
>   "Run a `rpmbuild -bp'."
>@@ -1403,8 +1420,8 @@
>            rpm-spec-mode-version
>            " by Stig Bjørlykke, <stigb@tihlde.org>")))
> 
>-;;;###autoload(add-to-list 'auto-mode-alist '("\\.spec\$\\.in\$?$" . rpm-spec-mode))
>-
>-(provide 'rpm-spec-mode)
>+;;;###autoload
>+(define-compilation-mode rpmbuild-mode "RPM spec" ""
>+  (set (make-local-variable 'compilation-disable-input) t))
> 
> ;;; rpm-spec-mode.el ends here

Actions: View | Diff

Attachments on bug 227418: 147407 | 277611 | 303198 | 303316