Attachment 303315 Details for Bug 443604 – map about button to about dialog instead of help

[patch] map about button to about dialog instead of help

show-about-dialog.patch (text/plain), 1.96 KB, created by ritz on 2008-04-22 14:32:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ritz

Created: 2008-04-22 14:32:54 UTC

Size: 1.96 KB

patch

obsolete

>--- virt-manager/virtManager/engine.py	2008-04-23 16:47:51.000000000 +0530
>+++ virt-manager-0.5.3/src/virtManager/engine.py	2008-01-11 06:47:51.000000000 +0530
>@@ -220,7 +220,7 @@
> 
>         if self.connections[uri]["windowHost"] == None:
>             manager = vmmHost(self.get_config(), con)
>-            manager.connect("action-show-about", self._do_show_about)
>+            manager.connect("action-show-help", self._do_show_help)
>             self.connections[uri]["windowHost"] = manager
>         self.connections[uri]["windowHost"].show()
> 
>--- virt-manager/virtManager/host.py	2008-04-23 16:47:51.000000000 +0530
>+++ virt-manager-0.5.3/src/virtManager/host.py	2008-01-11 06:47:51.000000000 +0530
>@@ -30,8 +30,8 @@
> 
> class vmmHost(gobject.GObject):
>     __gsignals__ = {
>-        "action-show-about": (gobject.SIGNAL_RUN_FIRST,
>-                               gobject.TYPE_NONE, []),
>+        "action-show-help": (gobject.SIGNAL_RUN_FIRST,
>+                               gobject.TYPE_NONE, [str]),
>         }
>     def __init__(self, config, conn):
>         self.__gobject_init__()
>@@ -88,7 +88,7 @@
>         self.window.signal_autoconnect({
>             "on_menu_file_close_activate": self.close,
>             "on_vmm_host_delete_event": self.close,
>-            "on_menu_help_about_activate": self.show_about,
>+            "on_menu_help_about_activate": self.show_help,
>             "on_net_add_clicked": self.add_network,
>             "on_net_delete_clicked": self.delete_network,
>             "on_net_stop_clicked": self.stop_network,
>@@ -139,8 +139,9 @@
>             self.add = vmmCreateNetwork(self.config, self.conn)
>         self.add.show()
> 
>-    def show_about(self, src):
>-        self.emit("action-show-about")
>+    def show_help(self, src):
>+        # From the Details window, show the help document from the Details page
>+        self.emit("action-show-help", "virt-manager-host-window")
> 
>     def close(self,ignore1=None,ignore2=None):
>         self.window.get_widget("vmm-host").hide()

Actions: View | Diff

Attachments on bug 443604: 303315 | 303319 | 316966