Attachment 303409 Details for Bug 443463 – The patch to fix the "rename fieldid "

[patch] The patch to fix the "rename fieldid "

3.1.patch (text/plain), 2.31 KB, created by XINSUN on 2008-04-23 02:10:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: XINSUN

Created: 2008-04-23 02:10:28 UTC

Size: 2.31 KB

patch

obsolete

>Index: Bugzilla/BugMail.pm
>===================================================================
>RCS file: /cvs/qa/hwcert/Bugzilla/BugMail.pm,v
>retrieving revision 1.4
>diff -u -r1.4 BugMail.pm
>--- Bugzilla/BugMail.pm	19 Jul 2007 19:31:53 -0000	1.4
>+++ Bugzilla/BugMail.pm	23 Apr 2008 02:08:06 -0000
>@@ -214,7 +214,7 @@
>             "       bug_when, removed, added, attach_id, fielddefs.name " .
>             "FROM bugs_activity, fielddefs, profiles " .
>             "WHERE bug_id = $id " .
>-            "  AND fielddefs.fieldid = bugs_activity.fieldid " .
>+            "  AND fielddefs.id = bugs_activity.fieldid " .
>             "  AND profiles.userid = who " .
>             $datepart . 
>             " ORDER BY bug_when"
>@@ -265,7 +265,7 @@
>             "WHERE bugs_activity.bug_id = dependencies.dependson " .
>             "  AND bugs.bug_id = bugs_activity.bug_id ".
>             "  AND dependencies.blocked = $id " .
>-            "  AND fielddefs.fieldid = bugs_activity.fieldid" .
>+            "  AND fielddefs.id = bugs_activity.fieldid" .
>             "  AND (fielddefs.name = 'bug_status' " .
>             "    OR fielddefs.name = 'resolution') " .
>             $datepart . 
>Index: CGI.pl
>===================================================================
>RCS file: /cvs/qa/hwcert/CGI.pl,v
>retrieving revision 1.2
>diff -u -r1.2 CGI.pl
>--- CGI.pl	23 Jul 2007 16:24:24 -0000	1.2
>+++ CGI.pl	23 Apr 2008 02:08:06 -0000
>@@ -336,7 +336,7 @@
>         bugs_activity.added,
>         profiles.realname
>     FROM bugs_activity $suppjoins LEFT JOIN fielddefs ON
>-        bugs_activity.fieldid = fielddefs.fieldid,
>+        bugs_activity.fieldid = fielddefs.id,
>         profiles
>     WHERE bugs_activity.bug_id = $id $datepart
>         AND profiles.userid = bugs_activity.who $suppwhere
>Index: globals.pl
>===================================================================
>RCS file: /cvs/qa/hwcert/globals.pl,v
>retrieving revision 1.23
>diff -u -r1.23 globals.pl
>--- globals.pl	31 Oct 2007 14:18:20 -0000	1.23
>+++ globals.pl	23 Apr 2008 02:08:06 -0000
>@@ -159,7 +159,7 @@
> 
> sub GetFieldID {
>     my ($f) = (@_);
>-    SendSQL("SELECT fieldid FROM fielddefs WHERE name = " . SqlQuote($f));
>+    SendSQL("SELECT id FROM fielddefs WHERE name = " . SqlQuote($f));
>     my $fieldid = FetchOneColumn();
>     die "Unknown field id: $f" if !$fieldid;
>     return $fieldid;

Actions: View | Diff

Attachments on bug 443463: 303409