Attachment 303411 Details for Bug 443566 – The patch to fix the "delete the refreshed_when "

[patch] The patch to fix the "delete the refreshed_when "

9.2.patch (text/plain), 4.02 KB, created by XINSUN on 2008-04-23 02:15:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: XINSUN

Created: 2008-04-23 02:15:49 UTC

Size: 4.02 KB

patch

obsolete

>Index: Bugzilla/User.pm
>===================================================================
>RCS file: /cvs/qa/hwcert/Bugzilla/User.pm,v
>retrieving revision 1.1.1.1
>diff -u -r1.1.1.1 User.pm
>--- Bugzilla/User.pm	16 Nov 2004 16:42:36 -0000	1.1.1.1
>+++ Bugzilla/User.pm	23 Apr 2008 02:12:24 -0000
>@@ -100,27 +100,6 @@
> 
>     bless ($self, $class);
> 
>-    # Now update any old group information if needed
>-    my $result = $dbh->selectrow_array(q{SELECT 1
>-                                           FROM profiles, groups
>-                                          WHERE userid=?
>-                                            AND profiles.refreshed_when <=
>-                                                  groups.last_changed},
>-                                       undef,
>-                                       $id);
>-
>-    if ($result) {
>-        my $is_main_db;
>-        unless ($is_main_db = Bugzilla->dbwritesallowed()) {
>-            Bugzilla->switch_to_main_db();
>-        }
>-        # FIXME Throws error due to unique constraint differences in current db
>-        #$self->derive_groups($tables_locked_for_derive_groups);
>-        unless ($is_main_db) {
>-            Bugzilla->switch_to_shadow_db();
>-        }
>-    }
>-
>     return $self;
> }
> 
>@@ -671,73 +650,6 @@
> 
> }
> 
>-sub email_prefs {
>-    # Get or set (not implemented) the user's email notification preferences.
>-    
>-    my $self = shift;
>-    
>-    # If the calling code is setting the email preferences, update the object
>-    # but don't do anything else.  This needs to write email preferences back
>-    # to the database.
>-    if (@_) { $self->{email_prefs} = shift; return; }
>-    
>-    # If we already got them from the database, return the existing values.
>-    return $self->{email_prefs} if $self->{email_prefs};
>-    
>-    # Retrieve the values from the database.
>-    &::SendSQL("SELECT emailflags FROM profiles WHERE userid = $self->{id}");
>-    my ($flags) = &::FetchSQLData();
>-
>-    my @roles = qw(Owner Reporter QAcontact CClist Voter);
>-    my @reasons = qw(Removeme Comments Attachments Status Resolved Keywords 
>-                     CC Other Unconfirmed);
>-
>-    # If the prefs are empty, this user hasn't visited the email pane
>-    # of userprefs.cgi since before the change to use the "emailflags" 
>-    # column, so initialize that field with the default prefs.
>-    if (!$flags) {
>-        # Create a default prefs string that causes the user to get all email.
>-        $flags = "ExcludeSelf~on~FlagRequestee~on~FlagRequester~on~";
>-        foreach my $role (@roles) {
>-            foreach my $reason (@reasons) {
>-                $flags .= "email$role$reason~on~";
>-            }
>-        }
>-        chop $flags;
>-    }
>-
>-    # Convert the prefs from the flags string from the database into
>-    # a Perl record.  The 255 param is here because split will trim 
>-    # any trailing null fields without a third param, which causes Perl 
>-    # to eject lots of warnings. Any suitably large number would do.
>-    my $prefs = { split(/~/, $flags, 255) };
>-    
>-    # Determine the value of the "excludeself" global email preference.
>-    # Note that the value of "excludeself" is assumed to be off if the
>-    # preference does not exist in the user's list, unlike other 
>-    # preferences whose value is assumed to be on if they do not exist.
>-    $prefs->{ExcludeSelf} = 
>-      exists($prefs->{ExcludeSelf}) && $prefs->{ExcludeSelf} eq "on";
>-    
>-    # Determine the value of the global request preferences.
>-    foreach my $pref (qw(FlagRequestee FlagRequester)) {
>-        $prefs->{$pref} = !exists($prefs->{$pref}) || $prefs->{$pref} eq "on";
>-    }
>-    
>-    # Determine the value of the rest of the preferences by looping over
>-    # all roles and reasons and converting their values to Perl booleans.
>-    foreach my $role (@roles) {
>-        foreach my $reason (@reasons) {
>-            my $key = "email$role$reason";
>-            $prefs->{$key} = !exists($prefs->{$key}) || $prefs->{$key} eq "on";
>-        }
>-    }
>-
>-    $self->{email_prefs} = $prefs;
>-    
>-    return $self->{email_prefs};
>-}
>-
> 1;
> 
> __END__

Actions: View | Diff

Attachments on bug 443566: 303411 | 303720 | 303788