Attachment 303946 Details for Bug 444400 – Upstream patch

[patch] Upstream patch

kronolith-CVE-2008-1974.patch (text/plain), 2.65 KB, created by Tomas Hoger on 2008-04-28 08:38:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomas Hoger

Created: 2008-04-28 08:38:36 UTC

Size: 2.65 KB

patch

obsolete

>diff -pruN kronolith-h3-2.1.7/addevent.php kronolith-h3-2.1.8/addevent.php
>--- kronolith-h3-2.1.7/addevent.php	2007-01-02 14:55:04.000000000 +0100
>+++ kronolith-h3-2.1.8/addevent.php	2008-04-27 19:38:45.000000000 +0200
>@@ -43,8 +43,6 @@ if (!$timestamp = Util::getFormData('tim
>     $timestamp = mktime($hour, 0, 0, $month, $day, $year);
> }
> 
>-$url = Util::getFormData('url');
>-
> $event->start = &new Horde_Date($timestamp);
> // Default to a 1 hour duration.
> $event->end = &new Horde_Date($timestamp + 3600);
>@@ -53,7 +51,7 @@ $month = $event->start->month;
> $year = $event->start->year;
> 
> $buttons = array('<input type="submit" class="button" name="save" value="' . _("Save Event") . '" onclick="return checkCategory();" />');
>-if (isset($url)) {
>+if ($url = Util::getFormData('url')) {
>     $cancelurl = $url;
> } else {
>     $cancelurl = Util::addParameter('month.php', 'month', $month);
>diff -pruN kronolith-h3-2.1.7/docs/CHANGES kronolith-h3-2.1.8/docs/CHANGES
>--- kronolith-h3-2.1.7/docs/CHANGES	2008-01-09 14:32:28.000000000 +0100
>+++ kronolith-h3-2.1.8/docs/CHANGES	2008-04-27 19:38:45.000000000 +0200
>@@ -1,4 +1,12 @@
> ------
>+v2.1.8
>+------
>+
>+[cjh] SECURITY: Fix XSS in the add event screen.
>+[jan] Add Turkish translation (Altay Ozaygen <horde-tr@metu.edu.tr>).
>+
>+
>+------
> v2.1.7
> ------
> 
>diff -pruN kronolith-h3-2.1.7/templates/edit/edit.inc kronolith-h3-2.1.8/templates/edit/edit.inc
>--- kronolith-h3-2.1.7/templates/edit/edit.inc	2006-06-27 16:50:59.000000000 +0200
>+++ kronolith-h3-2.1.8/templates/edit/edit.inc	2008-04-27 19:38:45.000000000 +0200
>@@ -32,7 +32,7 @@
>  <td></td>
>  <td colspan="4">
>   <?php echo implode("\n", $buttons) ?>
>-  <input type="submit" name="cancel" class="button" value="<?php echo _("Cancel") ?>" onclick="self.location = '<?php echo $cancelurl ?>'; return false;" />
>+  <?php echo Horde::link(htmlspecialchars($cancelurl), '', 'button') . _("Cancel") . '</a>' ?>
>   <input type="button" name="resetButton" class="button" value="<?php echo _("Reset to Defaults") ?>" onclick="document.event.reset(); updateWday('start_wday'); updateWday('end_wday');" />
>  </td>
> </tr>
>@@ -305,7 +305,7 @@ if ($browser->hasFeature('javascript')) 
>  <td></td>
>  <td colspan="4">
>   <?php echo implode("\n", $buttons) ?>
>-  <input type="submit" name="cancel" class="button" value="<?php echo _("Cancel") ?>" onclick="self.location = '<?php echo $cancelurl ?>'; return false;" />
>+  <?php echo Horde::link(htmlspecialchars($cancelurl), '', 'button') . _("Cancel") . '</a>' ?>
>   <input type="button" name="resetButton" class="button" value="<?php echo _("Reset to Defaults") ?>" onclick="document.event.reset(); updateWday('start_wday'); updateWday('end_wday');" />
>   </td>
>  </tr>

Actions: View | Diff

Attachments on bug 444400: 303946