Attachment 304100 Details for Bug 443564 – Patch improve:

[patch] Patch improve:

8.patch (text/plain), 2.52 KB, created by XINSUN on 2008-04-29 10:46:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: XINSUN

Created: 2008-04-29 10:46:56 UTC

Size: 2.52 KB

patch

obsolete

>Index: Bugzilla/User.pm
>===================================================================
>RCS file: /cvs/qa/hwcert/Bugzilla/User.pm,v
>retrieving revision 1.1.1.1
>diff -u -r1.1.1.1 User.pm
>--- Bugzilla/User.pm	16 Nov 2004 16:42:36 -0000	1.1.1.1
>+++ Bugzilla/User.pm	29 Apr 2008 10:43:39 -0000
>@@ -160,7 +139,7 @@
>     return $self->{queries} if defined $self->{queries};
> 
>     my $dbh = Bugzilla->dbh;
>-    my $sth = $dbh->prepare(q{  SELECT name, query, linkinfooter
>+    my $sth = $dbh->prepare(q{  SELECT name, query 
>                                   FROM namedqueries
>                                  WHERE userid=?
>                               ORDER BY UPPER(name)});
>@@ -171,7 +150,6 @@
>         push (@queries, {
>                           name         => $row->[0],
>                           query        => $row->[1],
>-                          linkinfooter => $row->[2],
>                         });
>     }
>     $self->{queries} = \@queries;
>Index: template/en/default/global/useful-links.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/global/useful-links.html.tmpl,v
>retrieving revision 1.1.1.1
>diff -u -r1.1.1.1 useful-links.html.tmpl
>--- template/en/default/global/useful-links.html.tmpl	16 Nov 2004 16:42:37 -0000	1.1.1.1
>+++ template/en/default/global/useful-links.html.tmpl	29 Apr 2008 10:43:39 -0000
>@@ -71,8 +71,7 @@
>         <a href="userprefs.cgi">Prefs</a>
>         [% ' | <a href="editparams.cgi">Parameters</a>' 
>                                                   IF user.groups.tweakparams %]
>-        [% ' | <a href="editusers.cgi">Users</a>'     IF user.groups.editusers 
>-                                                  || user.can_bless %]
>+        [% ' | <a href="editusers.cgi">Users</a>'     IF user.groups.editusers %]
>         [% ' | <a href="editproducts.cgi">Products</a>' 
>                                                IF user.groups.editcomponents %]
>         [% ' | <a href="editflagtypes.cgi">Flags</a>'
>@@ -100,14 +99,6 @@
>           <a href="[% Param('mybugstemplate').replace('%userid%', filtered_username) %]">My&nbsp;[% terms.Bugs %]</a>
>           [% print_pipe = 1 %]
>         [% END %]
>-
>-        [% FOREACH q = user.queries %]
>-          [% IF q.linkinfooter %]
>-            [% " | " IF print_pipe %]
>-            <a href="buglist.cgi?cmdtype=runnamed&amp;namedcmd=[% q.name FILTER url_quote %]"><nobr>[% q.name FILTER html %]</nobr></a>
>-            [% print_pipe = 1 %]
>-          [% END %]
>-        [% END %]
>     </div>
>   </div>
> </div>

Actions: View | Diff

Attachments on bug 443564: 303738 | 304100 | 304130