Attachment 304152 Details for Bug 442502 – Copies metadata during Ogg encode

[patch] Copies metadata during Ogg encode

callbacks.py.patch (text/plain), 1.39 KB, created by Wil Cooley on 2008-04-29 19:29:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Wil Cooley

Created: 2008-04-29 19:29:37 UTC

Size: 1.39 KB

patch

obsolete

>diff -up ./callbacks.py.orig ./callbacks.py
>--- ./callbacks.py.orig	2008-04-29 11:50:58.000000000 -0700
>+++ ./callbacks.py	2008-04-29 12:26:58.000000000 -0700
>@@ -911,7 +911,7 @@ The converted files may left in an incom
>       refreshCurrentFile(self, i, currFile, total)
> 
>       #decode
>-      if outputFormat == 'MP3' or outputFormat == 'FLAC': # only two of four because other two set tags during encode
>+      if hasattr(inputFormatObject, 'getTags'):
>         verbose('get tags')
>         self.setStatus(_('Retrieving tags/metadata'))
>         if self.ui.main2MetatagRadio1.get_active() and inputFormat != 'WAV':
>@@ -939,6 +939,7 @@ The converted files may left in an incom
>         else:
>           tags = None
>       else:
>+        verbose('Output format ' + outputFormat + ' does not support metadata or not implemented')
>         tags = None
>       if not self.encodeonly:
>         verbose('decode')
>@@ -1042,10 +1043,10 @@ The converted files may left in an incom
>           verbose(sub.stdout.readlines())
>           verbose(command)
>       #tags
>-      verbose(tags)
>+      verbose('Tags: ' + `tags`)
>       self.setStatus(_('Setting tags/metadata'))
>       if tags:
>-        if outputFormat == 'MP3' or  outputFormat == 'OGG' or outputFormat == 'FLAC' or outputFormat == 'AAC':
>+        if hasattr(outputFormat, 'setTags'):
>           outputFormatObject.setTags(newname, tags)
> 
>       # setup for next file

Actions: View | Diff

Attachments on bug 442502: 302411 | 304152